-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(website): Fix unknown chain bug in package page #1300
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9ef2daa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
return { | ||
id: chainId, | ||
name: 'Unknown Chain', | ||
color: 'gray.600', | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if we should return a viem.Chain
object here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do that just in case, good catch :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref:
cannon/packages/cli/src/chains.ts
Line 25 in e00d869
return { |
…nto fix-web-unknown-chain
When an unknown chain id is used in a package, we get an application error when trying to access that packages page on the web app.
Added a placeholder chain config so that when unknown chains are used, it defaults to that.