Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): Fix unknown chain bug in package page #1300

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

FuzzB0t
Copy link
Contributor

@FuzzB0t FuzzB0t commented Aug 20, 2024

When an unknown chain id is used in a package, we get an application error when trying to access that packages page on the web app.

Added a placeholder chain config so that when unknown chains are used, it defaults to that.

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 9ef2daa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9ef2daa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@FuzzB0t FuzzB0t requested a review from a team August 20, 2024 18:13
Copy link
Contributor

@nicosampler nicosampler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment on lines 79 to 83
return {
id: chainId,
name: 'Unknown Chain',
color: 'gray.600',
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we should return a viem.Chain object here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that just in case, good catch :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

@FuzzB0t FuzzB0t disabled auto-merge August 21, 2024 00:58
@FuzzB0t FuzzB0t merged commit 23551d8 into main Aug 23, 2024
7 of 9 checks passed
@FuzzB0t FuzzB0t deleted the fix-web-unknown-chain branch August 23, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants