Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): adding exponential backoff to ipfs calls #1263

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

FuzzB0t
Copy link
Contributor

@FuzzB0t FuzzB0t commented Aug 14, 2024

Adds retryDelay exponential backoff to axios module on our IPFS class.

We can set a custom retry condition but I think the default condition is good.

According to the AxiosRetry documentation the default condition to retry is if it is a network error or a 5xx error on an idempotent request (GET, HEAD, OPTIONS, PUT or DELETE).`

fixes https://linear.app/usecannon/issue/CAN-429/add-an-exponential-backoff-when-receiving-503-from-ipfs-upload-and

Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 10eae3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 10eae3d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@FuzzB0t FuzzB0t changed the title fix(builder): adding exponential backoff to axios retry module fix(builder): adding exponential backoff to ipfs calls Aug 14, 2024
@FuzzB0t FuzzB0t merged commit 974cd7b into main Aug 19, 2024
7 of 9 checks passed
@FuzzB0t FuzzB0t deleted the ipfs-exponential-backoff branch August 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants