-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(builder): fix invoke getInputs take array or string #1243
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2136a3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to double check the board, but I thought that previously we determined that we thought it was useful to have the ability to specify Target as non-array in the past. If that was the case, we may want to rethink our approach here and fix it so it is able to take non-array in the get inputs function.
Otherwise it looks good
Turns out the error only happened because we allowed targets to be defined as strings as well which was causing the
getInputs
function to incorrectly return values, causing the computation of dependencies to fail.fixes https://linear.app/usecannon/issue/CAN-405/invoke-implicit-depends-bug