Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): fix invoke getInputs take array or string #1243

Merged
merged 14 commits into from
Aug 14, 2024

Conversation

FuzzB0t
Copy link
Contributor

@FuzzB0t FuzzB0t commented Aug 8, 2024

Turns out the error only happened because we allowed targets to be defined as strings as well which was causing the getInputs function to incorrectly return values, causing the computation of dependencies to fail.

fixes https://linear.app/usecannon/issue/CAN-405/invoke-implicit-depends-bug

Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: 2136a3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2136a3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to double check the board, but I thought that previously we determined that we thought it was useful to have the ability to specify Target as non-array in the past. If that was the case, we may want to rethink our approach here and fix it so it is able to take non-array in the get inputs function.

Otherwise it looks good

@FuzzB0t FuzzB0t changed the title fix(builder): Force use of array on invoke target fix(builder): fix invoke getInputs take array or string Aug 13, 2024
@saeta-eth saeta-eth merged commit 5246f47 into main Aug 14, 2024
6 of 9 checks passed
@saeta-eth saeta-eth deleted the implicit-depends-order branch August 14, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants