Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(website): useQueryIpfsData #1236

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Conversation

nicosampler
Copy link
Contributor

This PR addresses the lack of typing in the useQueryIpfsData hook, which has been split into two distinct hooks: useQueryIpfsDataParsed for converting data into JSON objects and useQueryIpfsDataRaw for retrieving raw data as an ArrayBuffer. This change ensures components can reliably understand the data type returned and correctly handle errors.

The motivation for this change was that the frontend was unprepared to manage scenarios where data parsing failed when calling useQueryIpfsData.

Modifications have been made where the dApp previously utilized the original hook to now use either useQueryIpfsDataRaw or useQueryIpfsDataParsed, depending on the expected data format.

Due to the widespread impact of these changes, a deep code review and extensive testing of the dApp are recommended.

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: ca26e39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ca26e39. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@nicosampler nicosampler requested a review from saeta-eth August 2, 2024 19:41
@nicosampler nicosampler merged commit 83843fd into main Aug 3, 2024
7 of 9 checks passed
@nicosampler nicosampler deleted the website-refactor-useIpfsQuery branch August 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants