refactor(website): useQueryIpfsData #1236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the lack of typing in the
useQueryIpfsData
hook, which has been split into two distinct hooks:useQueryIpfsDataParsed
for converting data into JSON objects anduseQueryIpfsDataRaw
for retrieving raw data as an ArrayBuffer. This change ensures components can reliably understand the data type returned and correctly handle errors.The motivation for this change was that the frontend was unprepared to manage scenarios where data parsing failed when calling
useQueryIpfsData
.Modifications have been made where the dApp previously utilized the original hook to now use either
useQueryIpfsDataRaw
oruseQueryIpfsDataParsed
, depending on the expected data format.Due to the widespread impact of these changes, a deep code review and extensive testing of the dApp are recommended.