Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): hide loading when re-fetching txs information #1227

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Jul 29, 2024

This PR adds a UI improvement when transactions are re-fetching. Now it does not show a spinner when a new re-fetch is triggered, for example, when re-visiting the tab.

Closes #358.

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: e079d64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Jul 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e079d64. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@saeta-eth saeta-eth changed the title fix(website): can-358 hide loading when re-fetching txs information fix(website): hide loading when re-fetching txs information Jul 30, 2024
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any other places where we have made similar mistakes?

anyway lets merge this asap have heard tons of people complaining about this 😆

@nicosampler nicosampler merged commit 990df3c into main Aug 1, 2024
8 of 9 checks passed
@nicosampler nicosampler deleted the fix/can-358 branch August 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants