fix(builder): Fix output clash on var steps

packages/builder/src/definition.test.ts

@@ -48,6 +48,22 @@ describe('ChainDefinition', () => {
     });
   });
 
+  it('does not have output clash on var or settings', () => {
+    const rawDef: RawChainDefinition = {
+      name: 'test',
+      version: '1.0.0',
+      var: {
+        a: { b: '<%= settings.c %>', description: 'desc 1' },
+        d: { c: '1234', description: 'desc 2' },
+      },
+      deploy: {
+        woot: { artifact: 'wohoo', args: ['<%= settings.b %>'], depends: [] },
+      },
+    };
+
+    expect(new ChainDefinition(rawDef)).toBeTruthy;
+  });
+
   describe('validatePackageName()', () => {
     it('verifies the name is not too short', () => {
       expect(() => validatePackageName('hh')).toThrowError('must be at least');

packages/builder/src/definition.ts

@@ -104,7 +104,7 @@ export class ChainDefinition {
 
           for (const output of actionOutputs) {
             debug(`deps: ${fullActionName} provides ${output}`);
-            if (!this.dependencyFor.has(output)) {
+            if (!this.dependencyFor.has(output) || action === 'setting' || action === 'var') {
               this.dependencyFor.set(output, fullActionName);
             } else {
               throw new Error(`output clash: both ${this.dependencyFor.get(output)} and ${fullActionName} output ${output}`);