Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): stop the publishing process before sending an empty transaction #1194

Merged
merged 8 commits into from
Jul 12, 2024

Conversation

saeta-eth
Copy link
Contributor

Bug: Users can run the publish command twice and we're sending the second transaction basically without data.

Bug example:

Screenshot 2024-07-09 at 5 53 52 PM

Etherscan link from the transaction above:
https://sepolia-optimism.etherscan.io/tx/0xa2ae41e455e9be42b48fce84d6ba24e67072e539bc51b2801268fc9ffac1f66b

Copy link

changeset-bot bot commented Jul 9, 2024

⚠️ No Changeset found

Latest commit: f978655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Jul 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f978655. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@saeta-eth saeta-eth changed the title fix(cli): stopped the publishing process before sending an empty transaction fix(cli): stop the publishing process before sending an empty transaction Jul 9, 2024
@saeta-eth saeta-eth marked this pull request as ready for review July 11, 2024 15:24
@saeta-eth saeta-eth requested a review from a team July 11, 2024 15:24
@saeta-eth saeta-eth enabled auto-merge (squash) July 11, 2024 23:58
@saeta-eth saeta-eth merged commit 77684cc into main Jul 12, 2024
9 checks passed
@saeta-eth saeta-eth deleted the fix/empty-publish branch July 12, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants