-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): add strict validation to steps attributes #1116
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 11ea4b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Overall looks good! As far as I can see, something went wrong in the |
b3e1d00
to
8aac1dc
Compare
8aac1dc
to
0d57102
Compare
The e2e tests are failing because the |
56f658f
to
4bc1cf8
Compare
49cd824
to
11ea4b2
Compare
Closes https://linear.app/usecannon/issue/CAN-348/throw-an-error-if-you-have-stuff-in-your-operation-definition-thats
This PR does not allow to add invalid config values to step names, for example in
[deploy.Contract]
it would throw if you misspellartifact =
asartifacttt =
.