Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): package length check #1114

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix(builder): package length check #1114

merged 2 commits into from
Jun 13, 2024

Conversation

mjlescano
Copy link
Member

This PR fixes the correct handling of null terminators for the builder. Before that we where using ethers.js it adds an extra 00 at the end when calling ethers.utils.formatBytes32String, which meant that we couldn't register packages with 32 length, just 31. Since we moved to viem this is fixed because the stringToHex helper does not add the null terminator, and in turn this PR fixes the length validation to 32.

Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: e04508d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Jun 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e04508d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mjlescano mjlescano merged commit 486a39a into main Jun 13, 2024
9 checks passed
@mjlescano mjlescano deleted the fix-registry-validator branch June 13, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants