fix(builder): package length check #1114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the correct handling of null terminators for the builder. Before that we where using ethers.js it adds an extra
00
at the end when callingethers.utils.formatBytes32String
, which meant that we couldn't register packages with 32 length, just 31. Since we moved to viem this is fixed because thestringToHex
helper does not add the null terminator, and in turn this PR fixes the length validation to 32.