Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): offer to connect/switch to sign txn #1100

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

Ignusmart
Copy link
Contributor

Screencast.from.2024-06-07.09-37-41.webm

Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: a46004d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Jun 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a46004d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@@ -391,6 +391,7 @@ function QueueFromGitOps() {
try {
await switchChainAsync({ chainId: currentSafe?.chainId || 1 });
buildInfo.doBuild();
return;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug fix discovered during the development of this PR, in order to prevent executing doBuild() twice, since it is call also outside this if statement

@noahlitvin noahlitvin enabled auto-merge (squash) June 7, 2024 14:43
@noahlitvin noahlitvin merged commit 7af2a7c into main Jun 7, 2024
8 of 9 checks passed
@noahlitvin noahlitvin deleted the fix/sign-button branch June 7, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants