fix(cli): improve provider resolution outputs and remove sensitive information from debug logs #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2a9b3ae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
FuzzB0t
changed the title
|
Changes in this PR:
|
noisekit
reviewed
Sep 10, 2023
packages/cli/src/settings.ts
Outdated
| debug('got settings', finalSettings); | ||
| // Filter out private key for logging | ||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | ||
| const { cannonDirectory, privateKey, ...filteredSettings } = finalSettings; |
There was a problem hiding this comment.
- Provider ur contains api key
- Afaik many other places log full path and expose username
There was a problem hiding this comment.
Good catch thanks for the feedback @noisekit!
There was a problem hiding this comment.
also publishIpfsUrl contains auth in the url
There was a problem hiding this comment.
ideally those values not excluded from logs but replaced with smth like ****
FuzzB0t
changed the title
Merged
0xDmitry
pushed a commit
that referenced
this pull request
Oct 13, 2023
…formation from debug logs (#418)
This was referenced Oct 31, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 8, 2023
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.