-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove anvil from inspect command and add support for target string #364
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d3a6c17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title does not match contents
PR appears to be making change to allow for target to be an array or non-array, but the title states somethign completely different which isnt included.
packages/builder/src/schemas.zod.ts
Outdated
!!val.match(artifactNameRegex) || | ||
!!val.match(artifactPathRegex), | ||
(val) => ({ | ||
message: `"${val}" must be a valid ethereum address, previously defined contract step name, contract artifact name or filepath`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously defined contract step name
=> existing contract step name
its not necessary that the contract step was "previous" (although it must be depended upon) (soon we are getting rid of depends
so probably just best to keep response simple)
Yeah this PR contains both changes, although somewhat irrelevant to eachother, I'll change the PR title to match the contents better. |
No description provided.