Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID collisions in vue 2 #188

Closed
roamiiing opened this issue Apr 8, 2022 · 1 comment · Fixed by #239
Closed

ID collisions in vue 2 #188

roamiiing opened this issue Apr 8, 2022 · 1 comment · Fixed by #239

Comments

@roamiiing
Copy link

Hey! I am using this plugin really often with Vite and Vue 3. But now I am trying to use this plugin on Vue 2 and webpack 4 and getting collisions with IDs in attrs of svg elements.

I've looked at the code and noticed that there's this function, but it's only used in the compiler for Vue 3 .

Why is handling of ID collisions done only for Vue 3, and is there a possibility to do something like this for Vue 2?

@al3xnag
Copy link
Contributor

al3xnag commented Sep 22, 2022

+1. Please backport this fix 0908f60 to vue 2 compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants