-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Segoe MDL2 Assets Font Family Usage #4435
Comments
As usual, as soon as I file an issue things start behaving :) It appears Uno does correctly support the SymbolThemeFontFamily. I'm not sure why it wasn't working originally but I assume it was a mistake on my part. Points 2 and 3 are still valid. |
Note that upstream WinUI just fixed usage of the font name directly (microsoft/microsoft-ui-xaml#3923). It is now using the symbol font resource instead. Whenever Uno applies the latest styles (likely after the Windows design refresh) this should fix the issue (except for the docs). @MartinZikmund clarified the docs for this which may be enough: 5aa1202 |
@MartinZikmund Are Fluent v1 styles getting updated as well with #6374? I'm still not entirely sure how Uno organizes default control styles so that's hard for me to confirm with certainty. If so, this issue can be closed as I'm sure that PR is going to get merged. As stated, upstream WinUI fixed all default styles and is now using |
Should this be closed? |
Yes, I think so. With your commit to fix Fluent v1 and the release of Fluent v2 I think all instances of this have been fixed! |
What would you like to be added:
Running a previously UWP App in Uno, certain glyphs were not appearing correctly.
As a UWP-only code base, XAML such as
FontFamily="Segoe MDL2 Assets"
and code such asFontFamily = new FontFamily("Segoe MDL2 Assets")
was throughout the source. However, even in UWP this is considered bad practice and instead UWP apps should generally use theSymbolThemeFontFamily
-- fair enough. Source code was updated.This still didn't work on Android though (and likely all other platforms). It was also necessary to specially define this resource key -- and it has to be done for each head separately considering how fonts currently work in Uno:So pulling it all together:
Support theSymbolThemeFontFamily
resource key automatically in Uno. Define this in the Uno fluent styles for every head.<FontIcon FontFamily="Segoe MDL2 Assets" Glyph="" />
.Why is this needed:
So symbol glyphs work right out-of-the-box if UWP apps correctly use
SymbolThemeFontFamily
For which Platform:
Anything Else
For point number 2 above, it should also be possible to update the WinUI source directly.
The text was updated successfully, but these errors were encountered: