Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSAL] Back button is not visible for WinAppSDK Packaged #2560

Closed
1 of 16 tasks
jhanvi03 opened this issue Sep 20, 2024 · 4 comments
Closed
1 of 16 tasks

[MSAL] Back button is not visible for WinAppSDK Packaged #2560

jhanvi03 opened this issue Sep 20, 2024 · 4 comments
Assignees
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@jhanvi03
Copy link

jhanvi03 commented Sep 20, 2024

Current behavior

When a Project is created for MSAL and launching solution for WinAppSDK Packaged, the back button is not visible. The back button is visible on WebAssembly, WebAssembly IIS Express, Android. Found the issue while testing Uno.SDK & template 5.3.112 but the issue is also present with 5.3.108.
Screenshot 2024-09-20 at 4 03 32 PM

Expected behavior

The back Icon should be visible for WinAppSDK ass well

Screenshot 2024-09-20 at 4 01 29 PM

How to reproduce it (as minimally and precisely as possible)

  1. Open VS
  2. Create a new uno project.
  3. From the Wizard uncheck MacCatalyst and Desktop (inorder to enable MSAL).
  4. Check MSAL from the authentication.
  5. Click on create project.
  6. Select WinAppSDK as a target solution
  7. Build the Solution
  8. Observe the missing Back Button\icon.

Environment

Nuget Package (s):
Uno.SDK & Template verison: 5.3.108, 5.3.112
Package Version(s):

Affected platform(s):

  • iOS
  • macOS (AppKit)
  • Mac Catalyst
  • Android
  • WebAssembly
  • Windows
  • Skia (WPF)
  • Skia (GTK on Linux/macOS/Windows)
  • Skia (Linux Framebuffer)
  • Build tasks

Visual Studio:

  • 2019 (version: )
  • 2022 (version: )
  • Visual Studio Code (version: )
  • Rider Windows (version: )
  • Rider macOS (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

Found issue while testing #2484 for https://github.com/unoplatform/private/issues/528

@jhanvi03 jhanvi03 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Sep 20, 2024
@agneszitte
Copy link
Contributor

cc @kazo0

@kazo0
Copy link
Contributor

kazo0 commented Sep 30, 2024

This may have been fixed by unoplatform/uno.toolkit.ui#1228

@Kunal22shah
Copy link
Contributor

image
It has been fixed now.

@jhanvi03
Copy link
Author

Able to see the back button/icon. Tested with sdk/template 5.5.24 & VS VSIX 5.5.30.

Screenshot 2024-10-28 at 10 27 51 PM Screenshot 2024-10-28 at 10 27 30 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

No branches or pull requests

4 participants