Skip to content
This repository was archived by the owner on Oct 30, 2022. It is now read-only.

Fix bug of accidentally deleting the build after compile #107

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

ksaaskil
Copy link
Contributor

@ksaaskil ksaaskil commented Jul 26, 2019

This had the side-effect that the build was deleted after npm run compile. The bad news is that type-errors in tests are not detected but I think we can live with that for a while. To re-add, as far as I can see we could

  1. Add a separate CI build step to compile tests. If running --clean after that, one would need to separately run npm run compile after the tests were cleaned.
  2. Modify test compile so that it does not delete stuff from the build. I don't currently know enough of about the lerna+tsconfig but I think we can worry about it later.

FYI @mikesol @idantene

@ksaaskil ksaaskil changed the title Do not compile tests when compiling. Fix bug of accidentally deleting the build after compile Jul 26, 2019
@ksaaskil ksaaskil merged commit b88a557 into dev Jul 26, 2019
@ksaaskil ksaaskil deleted the fix-missing-build branch July 26, 2019 07:49
@ksaaskil ksaaskil mentioned this pull request Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant