fix: rework build validation #523
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kricsleo
changed the title
|
Can you please write an overview of changes 🙏 |
|
Sure, I've updated the description. Looking forward to your feedback! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on the build validation:
Added "shamefully hoisted dependencies" validation
If a package is directly referenced by the source code (not from nested
node_modules) and isn’t listed in any dependency field (dependencies/devDependencies/peerDependencies/optionalDependencies), it will be flagged as a hoisted dependency. Resolves Should we warn about shamefully hoisted dependencies? #527.Fixed "unused dependencies" validation
Previously, this check ran after each build and stopped working due to some previous changes. Now, it runs only after all builds complete since dependencies may be partially used across builds—only then can we determine which are truly unused. Resolves Unused dependencies validation is not working #524.
Enhanced "missing outputs" validation
Previously, this check ran after each build. However, entries declared in
package.jsonmight be generated incrementally by multiple builds. Now, it runs only after all builds complete. Resolves PassingBuildConfig[]todefineBuildConfigfails on export validation if eachBuildConfigiterative populates the./distwith the exported files. #356.Refactored the "implicit dependencies" warning by consolidating them into a single clearer message and improved warning logs for better readability. Resolves Improve log trace for
Potential missing package.json fileswarning #268.Preview:
