fix(manifest): Create parent directories of dest archive path (#2213)

craciunoiuc · web-flow · commit bd23d6a9fa7f · 2025-03-06T22:07:57.000+02:00
Reviewed-by: Cezar Craciunoiu &lt;cezar.craciunoiu@unikraft.io&gt;
Approved-by: Cezar Craciunoiu &lt;cezar.craciunoiu@unikraft.io&gt;
diff --git a/manifest/pack_pull_archive.go b/manifest/pack_pull_archive.go
@@ -206,6 +206,10 @@ func pullArchive(ctx context.Context, manifest *Manifest, resource string, check
 			}
 		}
 
+		if err := os.MkdirAll(filepath.Dir(cache), 0o755); err != nil {
+			return fmt.Errorf("could not create parent directories: %v", err)
+		}
+
 		// Copy the completed download to the local cache path
 		if err := os.Rename(tmpCache, cache); err != nil {
 			return fmt.Errorf("could not move downloaded package '%s' to destination '%s': %v", tmpCache, cache, err)

Original file line number	Diff line number	Diff line change
`@@ -206,6 +206,10 @@ func pullArchive(ctx context.Context, manifest *Manifest, resource string, check`
`206`	`206`	`}`
`207`	`207`	`}`
`208`	`208`
	`209`	`+ if err := os.MkdirAll(filepath.Dir(cache), 0o755); err != nil {`
	`210`	`+ return fmt.Errorf("could not create parent directories: %v", err)`
	`211`	`+ }`
	`212`	`+`
`209`	`213`	`// Copy the completed download to the local cache path`
`210`	`214`	`if err := os.Rename(tmpCache, cache); err != nil {`
`211`	`215`	`return fmt.Errorf("could not move downloaded package '%s' to destination '%s': %v", tmpCache, cache, err)`