Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable warn(missing_docs) for all component crates #2109

Closed
sffc opened this issue Jun 24, 2022 · 1 comment
Closed

Enable warn(missing_docs) for all component crates #2109

sffc opened this issue Jun 24, 2022 · 1 comment
Assignees
@echeran
Labels
C-meta Component: Relating to ICU4X as a whole S-epic Size: Major project (create smaller child issues) T-docs-tests Type: Code change outside core library
Milestone
ICU4X 1.0 (Final)

Comments

@sffc
Copy link
Member

sffc commented Jun 24, 2022

All ICU component crates should be fully documented. To track this, we should enable warn(missing_docs) as suggested in boilerplate.md.

Pre-existing sub-issues:

This issue does not track utils or experimental crates.
@sffc sffc added T-docs-tests Type: Code change outside core library C-meta Component: Relating to ICU4X as a whole S-epic Size: Major project (create smaller child issues) labels Jun 24, 2022
@sffc sffc added this to the ICU4X 1.0 (Polish) milestone Jun 24, 2022
@sffc sffc mentioned this issue Jun 24, 2022
Merged
@echeran
Copy link
Contributor

echeran commented Jun 24, 2022 •
edited
Loading

component status
calendar complete
collator complete
collections complete
datetime complete
decimal complete (#1025)
icu complete
list complete
locale_transform complete
locid complete (#1028)
normalizer complete
plurals complete (#2108)
properties complete
timezone complete

This was referenced Jun 27, 2022
Merged
Merged
Merged
Merged
This was referenced Aug 18, 2022
Merged
Merged
@echeran echeran closed this as completed Aug 24, 2022
@echeran echeran mentioned this issue Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echeran echeran

Labels
C-meta Component: Relating to ICU4X as a whole S-epic Size: Major project (create smaller child issues) T-docs-tests Type: Code change outside core library
Projects
None yet
Milestone
ICU4X 1.0 (Final)
Development

No branches or pull requests
2 participants
@echeran @sffc