Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix export on url #4823

Merged
merged 15 commits into from
Sep 16, 2021
Merged

Feature/fix export on url #4823

merged 15 commits into from
Sep 16, 2021

Conversation

kalenmike
Copy link
Contributor

@kalenmike kalenmike commented Sep 16, 2021

This fix is to stop export.py from setting the path/to/weights as the full URL when a URL is passed.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced model exporting with remote weight file support 📡🚀

📊 Key Changes

  • A new utility function url2file added to utils/general.py.
  • Modification in export.py to support downloading model weights directly from a URL when exporting models.

🎯 Purpose & Impact

  • Simplify Model Deployment: Users can directly pass in a URL for model weights during export, streamlining the model setup process.
  • Impact on Users: Beneficial for users who store their models online, as they can now use URLs instead of downloading weights files manually 🌐✨.
  • Code Maintainability: The introduction of url2file for URL handling may improve maintainability and readability 📖🔧.

@glenn-jocher glenn-jocher merged commit 43b2817 into ultralytics:master Sep 16, 2021
glenn-jocher added a commit that referenced this pull request Sep 16, 2021
glenn-jocher added a commit that referenced this pull request Sep 16, 2021
@kalenmike kalenmike deleted the feature/fix-export-on-url branch September 17, 2021 07:35
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
* added callbacks

* added back callback to main

* added save_dir to callback output

* merged in upstream

* removed ghost code

* added url check

* Add url2file()

* Update file-only

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* added callbacks

* added back callback to main

* added save_dir to callback output

* merged in upstream

* removed ghost code

* added url check

* Add url2file()

* Update file-only

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants