Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Commit

Permalink
fix: disable newsletter casuing crash (#36)
Browse files Browse the repository at this point in the history
  • Loading branch information
@billyyyyy3320
billyyyyy3320 authored Jan 6, 2020
1 parent 64a45aa commit 3cddcc8
Show file tree
Hide file tree
Showing 6 changed files with 139 additions and 42 deletions.
4 changes: 4 additions & 0 deletions .eslintrc.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ module.exports = {
"prettier/vue",
],

parserOptions: {
parser: 'babel-eslint' // Support dynamic import
},

rules: {
'no-undef': ['error'],

Expand Down
51 changes: 27 additions & 24 deletions components/Newsletter.vue
View file
Original file line number Diff line number Diff line change
@@ -1,23 +1,25 @@
<template>
<SimpleNewsletter v-slot="{ slotProps }">
<div class="newsletter__title">{{ slotProps.title }}</div>
<div class="newsletter__content">{{ slotProps.content }}</div>
<div class="newsletter__fields">
<input
v-model="slotProps.mail"
class="newsletter__input"
type="email"
name="email"
aria-label="Email"
placeholder="Email"
required
autocapitalize="off"
autocorrect="off"
data-cy="email"
/>
<button type="submit" class="newsletter__button" data-cy="submit">
{{ slotProps.submitText }}
</button>
<div class="newsletter__wrap">
<div class="newsletter__title">{{ slotProps.title }}</div>
<div class="newsletter__content">{{ slotProps.content }}</div>
<div class="newsletter__fields">
<input
v-model="slotProps.mail"
class="newsletter__input"
type="email"
name="email"
aria-label="Email"
placeholder="Email"
required
autocapitalize="off"
autocorrect="off"
data-cy="email"
/>
<button type="submit" class="newsletter__button" data-cy="submit">
{{ slotProps.submitText }}
</button>
</div>
</div>
</SimpleNewsletter>
</template>
Expand All @@ -31,17 +33,18 @@ export default {

<style lang="stylus">
.newsletter
max-width none
.newsletter &__wrap
max-width none
&__fields
.newsletter &__fields
display grid
grid-template-columns 1fr 1fr
grid-gap 10px
&__input
.newsletter &__input
margin-bottom 0
&__button
.newsletter &__button
transition box-shadow 0.2s ease, transform 0.2s ease
&:hover
Expand All @@ -50,9 +53,9 @@ export default {
@media (max-width: $MQMobile)
.newsletter
&__fields
.newsletter &__fields
display block
&__input
.newsletter &__input
margin-bottom 10px
</style>
2 changes: 1 addition & 1 deletion example/.vuepress/config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ module.exports = {
endpoint:'https://billyyyyy3320.us4.list-manage.com/subscribe/post?u=4905113ee00d8210c2004e038&amp;id=bd18d40138'
}

return { ...blogPluginOptions, sitemap, comment,newsletter }
return { ...blogPluginOptions, sitemap, comment }
}

// paginationComponent: 'SimplePagination'
Expand Down
3 changes: 1 addition & 2 deletions layouts/Post.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@

<script>
import Toc from '@theme/components/Toc.vue'
import Newsletter from '@theme/components/Newsletter.vue'
import { Comment } from '@vuepress/plugin-blog/lib/client/components'
export default {
components: {
Toc,
Comment,
Newsletter,
Newsletter: () => import('@theme/components/Newsletter.vue'),
},
}
</script>
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
]
},
"dependencies": {
"@vuepress/plugin-blog": "^1.7.0",
"@vuepress/plugin-blog": "^1.7.1",
"@vuepress/plugin-medium-zoom": "1.0.0",
"@vuepress/plugin-nprogress": "1.0.0",
"@vuepress/plugin-pwa": "1.0.0",
Expand All @@ -51,6 +51,7 @@
"vue-feather-icons": "^4.21.0"
},
"devDependencies": {
"babel-eslint": "^10.0.3",
"conventional-changelog-cli": "^2.0.1",
"eslint": "^6.8.0",
"eslint-config-prettier": "^6.7.0",
Expand Down
118 changes: 104 additions & 14 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@
lodash "^4.17.13"
source-map "^0.5.0"

"@babel/generator@^7.7.4":
version "7.7.7"
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.7.7.tgz#859ac733c44c74148e1a72980a64ec84b85f4f45"
integrity sha512-/AOIBpHh/JU1l0ZFS4kiRCBnLi6OTHzh0RPk3h9isBxkkqELtQNFi1Vr/tiG9p1yfoUdKVwISuXWQR+hwwM4VQ==
dependencies:
"@babel/types" "^7.7.4"
jsesc "^2.5.1"
lodash "^4.17.13"
source-map "^0.5.0"

"@babel/helper-annotate-as-pure@^7.0.0":
version "7.0.0"
resolved "https://registry.yarnpkg.com/@babel/helper-annotate-as-pure/-/helper-annotate-as-pure-7.0.0.tgz#323d39dd0b50e10c7c06ca7d7638e6864d8c5c32"
Expand Down Expand Up @@ -101,13 +111,29 @@
"@babel/template" "^7.1.0"
"@babel/types" "^7.0.0"

"@babel/helper-function-name@^7.7.4":
version "7.7.4"
resolved "https://registry.yarnpkg.com/@babel/helper-function-name/-/helper-function-name-7.7.4.tgz#ab6e041e7135d436d8f0a3eca15de5b67a341a2e"
integrity sha512-AnkGIdiBhEuiwdoMnKm7jfPfqItZhgRaZfMg1XX3bS25INOnLPjPG1Ppnajh8eqgt5kPJnfqrRHqFqmjKDZLzQ==
dependencies:
"@babel/helper-get-function-arity" "^7.7.4"
"@babel/template" "^7.7.4"
"@babel/types" "^7.7.4"

"@babel/helper-get-function-arity@^7.0.0":
version "7.0.0"
resolved "https://registry.yarnpkg.com/@babel/helper-get-function-arity/-/helper-get-function-arity-7.0.0.tgz#83572d4320e2a4657263734113c42868b64e49c3"
integrity sha512-r2DbJeg4svYvt3HOS74U4eWKsUAMRH01Z1ds1zx8KNTPtpTL5JAsdFv8BNyOpVqdFhHkkRDIg5B4AsxmkjAlmQ==
dependencies:
"@babel/types" "^7.0.0"

"@babel/helper-get-function-arity@^7.7.4":
version "7.7.4"
resolved "https://registry.yarnpkg.com/@babel/helper-get-function-arity/-/helper-get-function-arity-7.7.4.tgz#cb46348d2f8808e632f0ab048172130e636005f0"
integrity sha512-QTGKEdCkjgzgfJ3bAyRwF4yyT3pg+vDgan8DSivq1eS0gwi+KGKE5x8kRcbeFTb/673mkO5SN1IZfmCfA5o+EA==
dependencies:
"@babel/types" "^7.7.4"

"@babel/helper-hoist-variables@^7.4.4":
version "7.4.4"
resolved "https://registry.yarnpkg.com/@babel/helper-hoist-variables/-/helper-hoist-variables-7.4.4.tgz#0298b5f25c8c09c53102d52ac4a98f773eb2850a"
Expand Down Expand Up @@ -196,6 +222,13 @@
dependencies:
"@babel/types" "^7.4.4"

"@babel/helper-split-export-declaration@^7.7.4":
version "7.7.4"
resolved "https://registry.yarnpkg.com/@babel/helper-split-export-declaration/-/helper-split-export-declaration-7.7.4.tgz#57292af60443c4a3622cf74040ddc28e68336fd8"
integrity sha512-guAg1SXFcVr04Guk9eq0S4/rWS++sbmyqosJzVs8+1fH5NI+ZcmkaSkc7dmtAFbHFva6yRJnjW3yAcGxjueDug==
dependencies:
"@babel/types" "^7.7.4"

"@babel/helper-wrap-function@^7.1.0":
version "7.2.0"
resolved "https://registry.yarnpkg.com/@babel/helper-wrap-function/-/helper-wrap-function-7.2.0.tgz#c4e0012445769e2815b55296ead43a958549f6fa"
Expand Down Expand Up @@ -224,6 +257,11 @@
esutils "^2.0.2"
js-tokens "^4.0.0"

"@babel/parser@^7.0.0", "@babel/parser@^7.7.4":
version "7.7.7"
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.7.7.tgz#1b886595419cf92d811316d5b715a53ff38b4937"
integrity sha512-WtTZMZAZLbeymhkd/sEaPD8IQyGAhmuTuvTzLiCFM7iXiVdY0gc0IaI+cW0fh1BnSMbJSzXX6/fHllgHKwHhXw==

"@babel/parser@^7.6.0", "@babel/parser@^7.6.3", "@babel/parser@^7.6.4":
version "7.6.4"
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.6.4.tgz#cb9b36a7482110282d5cb6dd424ec9262b473d81"
Expand Down Expand Up @@ -645,6 +683,30 @@
"@babel/parser" "^7.6.0"
"@babel/types" "^7.6.0"

"@babel/template@^7.7.4":
version "7.7.4"
resolved "https://registry.yarnpkg.com/@babel/template/-/template-7.7.4.tgz#428a7d9eecffe27deac0a98e23bf8e3675d2a77b"
integrity sha512-qUzihgVPguAzXCK7WXw8pqs6cEwi54s3E+HrejlkuWO6ivMKx9hZl3Y2fSXp9i5HgyWmj7RKP+ulaYnKM4yYxw==
dependencies:
"@babel/code-frame" "^7.0.0"
"@babel/parser" "^7.7.4"
"@babel/types" "^7.7.4"

"@babel/traverse@^7.0.0":
version "7.7.4"
resolved "https://registry.yarnpkg.com/@babel/traverse/-/traverse-7.7.4.tgz#9c1e7c60fb679fe4fcfaa42500833333c2058558"
integrity sha512-P1L58hQyupn8+ezVA2z5KBm4/Zr4lCC8dwKCMYzsa5jFMDMQAzaBNy9W5VjB+KAmBjb40U7a/H6ao+Xo+9saIw==
dependencies:
"@babel/code-frame" "^7.5.5"
"@babel/generator" "^7.7.4"
"@babel/helper-function-name" "^7.7.4"
"@babel/helper-split-export-declaration" "^7.7.4"
"@babel/parser" "^7.7.4"
"@babel/types" "^7.7.4"
debug "^4.1.0"
globals "^11.1.0"
lodash "^4.17.13"

"@babel/traverse@^7.1.0", "@babel/traverse@^7.4.4", "@babel/traverse@^7.5.5", "@babel/traverse@^7.6.2", "@babel/traverse@^7.6.3":
version "7.6.3"
resolved "https://registry.yarnpkg.com/@babel/traverse/-/traverse-7.6.3.tgz#66d7dba146b086703c0fb10dd588b7364cec47f9"
Expand All @@ -669,6 +731,15 @@
lodash "^4.17.13"
to-fast-properties "^2.0.0"

"@babel/types@^7.7.4":
version "7.7.4"
resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.7.4.tgz#516570d539e44ddf308c07569c258ff94fde9193"
integrity sha512-cz5Ji23KCi4T+YIE/BolWosrJuSmoZeN1EFnRtBwF+KKLi8GG/Z2c2hOJJeCXPk4mwk4QFvTmwIodJowXgttRA==
dependencies:
esutils "^2.0.2"
lodash "^4.17.13"
to-fast-properties "^2.0.0"

"@mrmlnc/readdir-enhanced@^2.2.1":
version "2.2.1"
resolved "https://registry.yarnpkg.com/@mrmlnc/readdir-enhanced/-/readdir-enhanced-2.2.1.tgz#524af240d1a360527b730475ecfa1344aa540dde"
Expand Down Expand Up @@ -937,17 +1008,17 @@
dependencies:
lodash.debounce "^4.0.8"

"@vuepress/plugin-blog@^1.7.0":
version "1.7.0"
resolved "https://registry.yarnpkg.com/@vuepress/plugin-blog/-/plugin-blog-1.7.0.tgz#7dbb951be3a17bb64f51a5313a28d04da4b85dd1"
integrity sha512-FAqBbMeQSRWVMf0cNUaP9tnMRyqG6W4o4EZlZ1X0AwETH66W3SAP8HrtfCCf5XEKnHnwzRjwqRi+mUGASMaEKQ==
"@vuepress/plugin-blog@^1.7.1":
version "1.7.1"
resolved "https://registry.yarnpkg.com/@vuepress/plugin-blog/-/plugin-blog-1.7.1.tgz#42a543937140d23ab9db8733aad8d2cb5ab57b15"
integrity sha512-+P81RQuo4wIhxaI2VegF/XMChoChSvD01YSEqymGEY55P8bi5hDqQ0EJaRx0Uy2IXWwLb6aLjpmVMR1L7A1t+g==
dependencies:
"@vssue/api-github-v3" "^1.1.2"
"@vssue/vuepress-plugin-vssue" "^1.2.0"
vuejs-paginate "^2.1.0"
vuepress-plugin-disqus-comment "^0.2.3"
vuepress-plugin-mailchimp "^1.3.1"
vuepress-plugin-sitemap "^2.3.0"
vuepress-plugin-mailchimp "^1.4.1"
vuepress-plugin-sitemap "^2.3.1"

"@vuepress/plugin-last-updated@^1.2.0":
version "1.2.0"
Expand Down Expand Up @@ -1554,6 +1625,18 @@ axios@^0.18.1:
follow-redirects "1.5.10"
is-buffer "^2.0.2"

babel-eslint@^10.0.3:
version "10.0.3"
resolved "https://registry.yarnpkg.com/babel-eslint/-/babel-eslint-10.0.3.tgz#81a2c669be0f205e19462fed2482d33e4687a88a"
integrity sha512-z3U7eMY6r/3f3/JB9mTsLjyxrv0Yb1zb8PCWCLpguxfCzBIZUwy23R1t/XKewP+8mEN2Ck8Dtr4q20z6ce6SoA==
dependencies:
"@babel/code-frame" "^7.0.0"
"@babel/parser" "^7.0.0"
"@babel/traverse" "^7.0.0"
"@babel/types" "^7.0.0"
eslint-visitor-keys "^1.0.0"
resolve "^1.12.0"

babel-extract-comments@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/babel-extract-comments/-/babel-extract-comments-1.0.0.tgz#0a2aedf81417ed391b85e18b4614e693a0351a21"
Expand Down Expand Up @@ -7753,6 +7836,13 @@ resolve@^1.10.0, resolve@^1.2.0, resolve@^1.3.2, resolve@^1.4.0, resolve@^1.8.1:
dependencies:
path-parse "^1.0.6"

resolve@^1.12.0:
version "1.14.1"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.14.1.tgz#9e018c540fcf0c427d678b9931cbf45e984bcaff"
integrity sha512-fn5Wobh4cxbLzuHaE+nphztHy43/b++4M6SsGFC2gB8uYwf0C8LcarfCz1un7UTW8OFQg9iNjZ4xpcFVGebDPg==
dependencies:
path-parse "^1.0.6"

restore-cursor@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/restore-cursor/-/restore-cursor-2.0.0.tgz#9f7ee287f82fd326d4fd162923d62129eee0dfaf"
Expand Down Expand Up @@ -9384,18 +9474,18 @@ vuepress-plugin-disqus-comment@^0.2.3:
dependencies:
vue-disqus "^3.0.5"

vuepress-plugin-mailchimp@^1.3.1:
version "1.3.1"
resolved "https://registry.yarnpkg.com/vuepress-plugin-mailchimp/-/vuepress-plugin-mailchimp-1.3.1.tgz#c2001d4b5dc526617094d834cba8c961d5792a40"
integrity sha512-oyS2DrM5Wnr2/dYoGEig/IQff+vRtt7YXj/yRWDMy+fu/yscdwVvkLjBwVsJBeqDx+GWL4pXQtHY3majHIwH8g==
vuepress-plugin-mailchimp@^1.4.1:
version "1.4.1"
resolved "https://registry.yarnpkg.com/vuepress-plugin-mailchimp/-/vuepress-plugin-mailchimp-1.4.1.tgz#458c4a65f633b0690acd650400e3af6769c947f2"
integrity sha512-U1KJe7zso1sMmhBnv9TL3wFj2yYrsTZe0+RqhQ4O8dvBinb2gdRMSuCOgtvTTaSeKTbL/jxD4g5LLnVJHaD9HA==
dependencies:
jsonp "^0.2.1"
query-string "^6.9.0"

vuepress-plugin-sitemap@^2.3.0:
version "2.3.0"
resolved "https://registry.yarnpkg.com/vuepress-plugin-sitemap/-/vuepress-plugin-sitemap-2.3.0.tgz#4fc2573b62235ca80db237fe5e407a241067318b"
integrity sha512-ClEpb/sUpLbiFqRi885532EcfLdB8KQ7CSU4Q8VEsk95h7Vk/MpDsdptAKvDTstY/3Rxua2xFEx2dcjTjeF8Gw==
vuepress-plugin-sitemap@^2.3.1:
version "2.3.1"
resolved "https://registry.yarnpkg.com/vuepress-plugin-sitemap/-/vuepress-plugin-sitemap-2.3.1.tgz#51298aca77a5de96396fdbd1103e1637dd61ae6a"
integrity sha512-n+8lbukhrKrsI9H/EX0EBgkE1pn85LAQFvQ5dIvrZP4Kz6JxPOPPNTQmZMhahQV1tXbLZQCEN7A1WZH4x+arJQ==
dependencies:
sitemap "^3.0.0"

Expand Down

0 comments on commit 3cddcc8

Please sign in to comment.