Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop overriding dit_adviser for new interactions #253

Merged
merged 2 commits into from
Jun 13, 2017

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Jun 13, 2017

As discussed with @jim68000, this stops the overriding of the dit_adviser that the front end was sending when creating interactions.

The front end will be amended to default to the current user when creating an interaction.

This change will also alter the behaviour of the home-page endpoint an interaction will show up on the home page of the user entered as the adviser for that interaction, which was discussed as more desirable.

@reupen reupen requested review from canni and elcct June 13, 2017 08:40
@codecov-io
Copy link

codecov-io commented Jun 13, 2017

Codecov Report

Merging #253 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #253      +/-   ##
===========================================
- Coverage    92.76%   92.74%   -0.02%     
===========================================
  Files           56       56              
  Lines         1990     1985       -5     
  Branches       179      178       -1     
===========================================
- Hits          1846     1841       -5     
  Misses         122      122              
  Partials        22       22
Impacted Files Coverage Δ
datahub/interaction/views.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74363a8...338b164. Read the comment docs.

@reupen reupen merged commit 7d7340e into develop Jun 13, 2017
@reupen reupen deleted the feature/dh-279-interaction-dit-adviser branch June 13, 2017 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants