Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MOM6 to its main branch 20220217 commit #1059

Closed
jiandewang opened this issue Feb 20, 2022 · 8 comments · Fixed by #1045
Closed

update MOM6 to its main branch 20220217 commit #1059

jiandewang opened this issue Feb 20, 2022 · 8 comments · Fixed by #1045
Labels
enhancement New feature or request

Comments

@jiandewang
Copy link
Collaborator

MOM6 main branch was updated on 20220217 (see detail at mom-ocean/MOM6#1556 (comment)), need to make corresponding updating in ufs-weather-model
Note these parameters default values have been changed:

  • INTERNAL_WAVE_SPEED_BETTER_EST (now .true.)
  • EPBL_MLD_BISECTION (now .false.)
  • BBL_USE_EOS (now set to the value of USE_EOS)

in MOM_input, we will set INTERNAL_WAVE_SPEED_BETTER_EST = False and EPBL_MLD_BISECTION = True explicitly to retain current answer. BBL_USE_EOS is set explicitly in current MOM_input so the change has no impact in answer

@DeniseWorthen
Copy link
Collaborator

@jiandewang I thought our general policy was to keep our MOM_input defaults consistent with the default values from GFDL.

@jiandewang
Copy link
Collaborator Author

jiandewang commented Feb 22, 2022

@DeniseWorthen you are right on the general policy. In fact those two parameters are set explicitly for 025 and 05 resolution in MOM6-examples now. See
https://github.com/NOAA-GFDL/MOM6-examples/blob/dev/gfdl/ice_ocean_SIS2/OM4_025/MOM_input#L389
https://github.com/NOAA-GFDL/MOM6-examples/blob/dev/gfdl/ice_ocean_SIS2/OM4_025/MOM_input#L711

But for 1x1 EPBL_MLD_BISECTION is not set explicitly in MOM6-example, thus I had to set it as T in UFS. If I remove this then we will need a new baseline for 1x1.
Correction: for 1x1 EPBL_MLD_BISECTION is not needed in setting as it is not being used

@DeniseWorthen
Copy link
Collaborator

@jiandewang I think I'm confused how you're describing the change. In the MOM_input templates, each of these three is being set to the Default setting.

@jiandewang
Copy link
Collaborator Author

jiandewang commented Feb 22, 2022

@DeniseWorthen let's say INTERNAL_WAVE_SPEED_BETTER_EST, the default is F in current dev/emc code, but in became T in the updated code. In current UFS MOM_template we didn't have this setting which means we are using default F. But in the updating we add it explicitly in MOM_template as F so that we can keep answer. So I am not setting it as default in this PR.

@jiandewang
Copy link
Collaborator Author

@DeniseWorthen I know your concern now, it is the documentation in MOM_template that I forgot to modify, will make that change shortly.

@jiandewang
Copy link
Collaborator Author

@DeniseWorthen I just updated MOM_template and ran all S2S and CDEPS on HERA, got all PASS

@DeniseWorthen
Copy link
Collaborator

So we're now setting these parameters as non-default values, solely to maintain our current baselines, correct? Should we plan on changing them to the actual defaults in a future commit which changes baselines?

@jiandewang
Copy link
Collaborator Author

@DeniseWorthen we will keep these parameters in MOM_template (MOM6-examples also did in this way)

@junwang-noaa junwang-noaa added the enhancement New feature or request label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants