-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update MOM6 to its main branch 20220217 commit #1059
Comments
@jiandewang I thought our general policy was to keep our MOM_input defaults consistent with the default values from GFDL. |
@DeniseWorthen you are right on the general policy. In fact those two parameters are set explicitly for 025 and 05 resolution in MOM6-examples now. See But for 1x1 EPBL_MLD_BISECTION is not set explicitly in MOM6-example, thus I had to set it as T in UFS. If I remove this then we will need a new baseline for 1x1. |
@jiandewang I think I'm confused how you're describing the change. In the MOM_input templates, each of these three is being set to the Default setting. |
@DeniseWorthen let's say INTERNAL_WAVE_SPEED_BETTER_EST, the default is F in current dev/emc code, but in became T in the updated code. In current UFS MOM_template we didn't have this setting which means we are using default F. But in the updating we add it explicitly in MOM_template as F so that we can keep answer. So I am not setting it as default in this PR. |
@DeniseWorthen I know your concern now, it is the documentation in MOM_template that I forgot to modify, will make that change shortly. |
@DeniseWorthen I just updated MOM_template and ran all S2S and CDEPS on HERA, got all PASS |
So we're now setting these parameters as non-default values, solely to maintain our current baselines, correct? Should we plan on changing them to the actual defaults in a future commit which changes baselines? |
@DeniseWorthen we will keep these parameters in MOM_template (MOM6-examples also did in this way) |
MOM6 main branch was updated on 20220217 (see detail at mom-ocean/MOM6#1556 (comment)), need to make corresponding updating in ufs-weather-model
Note these parameters default values have been changed:
in MOM_input, we will set INTERNAL_WAVE_SPEED_BETTER_EST = False and EPBL_MLD_BISECTION = True explicitly to retain current answer. BBL_USE_EOS is set explicitly in current MOM_input so the change has no impact in answer
The text was updated successfully, but these errors were encountered: