Remove some hard-coded constants and rename some meta entries

Author: SamuelTrahanNOAA

physics/GFS_rrtmg_pre.meta

@@ -1195,8 +1195,8 @@
   kind = kind_phys
   intent = out
 [aero_dir_fdb]
-  standard_name = rrfs_smoke_dust_rad_fdb_opt
-  long_name = flag for rrfs smoke dust rad feedback
+  standard_name = do_smoke_aerosol_direct_feedback
+  long_name = flag for smoke and dust radiation feedback
   units = flag
   dimensions = ()
   type = logical
@@ -1233,7 +1233,7 @@
   type = integer
   intent = in
 [rrfs_smoke_band]
-  standard_name = rrtmg_band_number_that_smoke_and_dust_should_affect
+  standard_name = index_of_shortwave_band_affected_by_smoke
   long_name = rrtmg band number that smoke and dust should affect
   units = count
   dimensions = ()

physics/mp_thompson.meta

@@ -436,8 +436,8 @@
   kind = kind_phys
   intent = in
 [aero_ind_fdb]
-  standard_name = rrfs_smoke_aero_ind_fdb_opt
-  long_name = flag for rrfs wfa ifa emission
+  standard_name = do_smoke_aerosol_indirect_feedback
+  long_name = flag for wfa ifa emission indirect feedback
   units = flag
   dimensions = ()
   type = logical

physics/mynnedmf_wrapper.meta

@@ -1353,21 +1353,21 @@
   intent = inout
 [frp]
   standard_name = frp_hourly
-  long_name = hourly frp
-  units = mw
+  long_name = hourly fire radiative power
+  units = MW
   dimensions = (horizontal_loop_extent)
   type = real
   kind = kind_phys
   intent = inout
 [mix_chem]
-  standard_name = rrfs_smoke_mynn_tracer_mixing
+  standard_name = do_planetary_boundary_layer_smoke_mixing
   long_name = flag for rrfs smoke mynn tracer mixing
   units = flag
   dimensions = ()
   type = logical
   intent = in
 [fire_turb]
-  standard_name = rrfs_smoke_mynn_enh_vermix
+  standard_name = do_planetary_boundary_layer_fire_enhancement
   long_name = flag for rrfs smoke mynn enh vermix
   units = flag
   dimensions = ()

smoke/dep_wet_ls_mod.F90

@@ -5,7 +5,6 @@ module dep_wet_ls_mod
   use rrfs_smoke_data
   use machine ,        only : kind_phys
   use rrfs_smoke_config
-  use physcons,        only : grav => con_g
 !  use chem_tracers_mod
 !  use chem_rc_mod
 !  use chem_tracers_mod
@@ -206,7 +205,7 @@ end subroutine wetdep_ls
 
   subroutine WetRemovalGOCART ( data,i1, i2, j1, j2, k1, k2, n1, n2, cdt, &
                                 num_chem, var_rmv, chem, ple, tmpu,  &
-                                rhoa, dqcond, precc, precl,         &
+                                rhoa, dqcond, precc, precl, grav,        &
                                 ims, ime, jms, jme, kms, kme)
 !                                ims, ime, jms, jme, kms, kme, rc )
 
@@ -217,7 +216,7 @@ subroutine WetRemovalGOCART ( data,i1, i2, j1, j2, k1, k2, n1, n2, cdt, &
 ! !INPUT PARAMETERS:
    integer, intent(in) :: i1, i2, j1, j2, k1, k2, n1, n2, num_chem, &
                           ims, ime, jms, jme, kms, kme
-   real(kind_phys), intent(in)    :: cdt
+   real(kind_phys), intent(in)    :: cdt, grav
    REAL(kind_phys),  DIMENSION( ims:ime , kms:kme , jms:jme ,1:num_chem),&
           INTENT(INOUT) :: chem
    REAL(kind_phys),  DIMENSION( ims:ime ,  jms:jme,num_chem ), &

smoke/module_plumerise1.F90

@@ -5,6 +5,7 @@ module module_plumerise1
 
   use rrfs_smoke_data
   use machine , only : kind_phys
+  real(kind=kind_phys),parameter :: p1000mb = 100000.  ! p at 1000mb (pascals)
 !- Implementing the fire radiative power (FRP) methodology for biomass burning
 !- emissions and convective energy estimation.
 !- Saulo Freitas, Gabriel Pereira (INPE/UFJS, Brazil)
@@ -37,7 +38,7 @@ module module_plumerise1
 subroutine ebu_driver (      data,flam_frac,ebb_smoke,ebu,           &
                              t_phy,q_vap,                            &   ! RAR: moist is replaced with q_vap
                              rho_phy,vvel,u_phy,v_phy,p_phy,         &
-                             z_at_w,z,ktau,                          &   ! scale_fire_emiss is part of config_flags
+                             z_at_w,z,ktau,g,con_cp,con_rd,          &   ! scale_fire_emiss is part of config_flags
                              plume_frp, k_min, k_max,                &   ! RAR:
                              ids,ide, jds,jde, kds,kde,              &
                              ims,ime, jms,jme, kms,kme,              &
@@ -66,6 +67,7 @@ subroutine ebu_driver (      data,flam_frac,ebb_smoke,ebu,           &
 !         INTENT(IN ) ::                                   moist
    real(kind=kind_phys), DIMENSION( ims:ime, kms:kme, jms:jme ), INTENT(INOUT ) ::  ebu
 
+   real(kind=kind_phys), INTENT(IN )  :: g, con_cp, con_rd
    real(kind=kind_phys), DIMENSION( ims:ime, jms:jme ), INTENT(IN )  :: ebb_smoke
    real(kind=kind_phys), DIMENSION( ims:ime, jms:jme ), INTENT(OUT ) :: flam_frac
 
@@ -87,7 +89,7 @@ subroutine ebu_driver (      data,flam_frac,ebb_smoke,ebu,           &
       !real(kind_phys), dimension (num_ebu) :: eburn_in
       !real(kind_phys), dimension (kte,num_ebu) :: eburn_out
       real(kind_phys), dimension (kte) :: u_in ,v_in ,w_in ,theta_in ,pi_in, rho_phyin ,qv_in ,zmid, z_lev
-      real(kind=kind_phys) :: dz_plume
+      real(kind=kind_phys) :: dz_plume, cpor, con_rocp
 
       !INTEGER, PARAMETER :: kfire_max=30  
 ! real(kind_phys), dimension(nveg_agreg) :: firesize,mean_fct
@@ -111,6 +113,8 @@ subroutine ebu_driver (      data,flam_frac,ebb_smoke,ebu,           &
 !                ebu(i,kts,j,p_ebu_pm10) = ebu_in(i,1,j,p_ebu_in_pm10)
 !            enddo
 !          enddo
+        cpor    =con_cp/con_rd
+        con_rocp=con_rd/con_cp
 
         IF ( dbg_opt .and. ktau<2000) then
            WRITE(*,*) 'module_plumerise1: its,ite,jts,jte ', its,ite,jts,jte
@@ -188,7 +192,8 @@ subroutine ebu_driver (      data,flam_frac,ebb_smoke,ebu,           &
                               u_in, v_in, w_in, theta_in ,pi_in,    &
                               rho_phyin, qv_in, zmid, z_lev,        &
                               plume_frp(i,j,1), k_min(i,j),         & 
-                              k_max(i,j), ktau, dbg_opt, errmsg, errflg )
+                              k_max(i,j), ktau, dbg_opt, g, con_cp, &
+                              con_rd, cpor, errmsg, errflg )
                              !k_max(i,j), ktau, config_flags%debug_chem )
                if(errflg/=0) return
 

smoke/module_smoke_plumerise.F90

@@ -16,24 +16,22 @@ module module_smoke_plumerise
   use machine , only : kind_phys
   use rrfs_smoke_data
   use rrfs_smoke_config, only : FIRE_OPT_GBBEPx, FIRE_OPT_MODIS
-  use physcons,        only : g => con_g, cp => con_cp, r_d => con_rd, r_v =>con_rv
   use plume_data_mod,  only : num_frp_plume, p_frp_hr, p_frp_std,                  &
                               !tropical_forest, boreal_forest, savannah, grassland,   &
                               wind_eff
   USE module_zero_plumegen_coms
 
-  real(kind=kind_phys),parameter :: p1000mb = 100000.  ! p at 1000mb (pascals)
-  real(kind=kind_phys),parameter :: rgas=r_d
-  real(kind=kind_phys),parameter :: cpor=cp/r_d
-  real(kind=kind_phys),parameter :: p00=p1000mb
+  !real(kind=kind_phys),parameter :: rgas=r_d
+  !real(kind=kind_phys),parameter :: cpor=cp/r_d
 CONTAINS
 
 ! RAR:
     subroutine plumerise(data,m1,m2,m3,ia,iz,ja,jz,             &
 !                         firesize,mean_fct,                         &
                         ! nspecies,eburn_in,eburn_out,               &
                          up,vp,wp,theta,pp,dn0,rv,zt_rams,zm_rams,  &
-                         frp_inst,k1,k2, ktau, dbg_opt, errmsg, errflg   )
+                         frp_inst,k1,k2, ktau, dbg_opt, g, cp, rgas, &
+                         cpor,  errmsg, errflg   )
 
   implicit none
   type(smoke_data), intent(inout) :: data
@@ -44,6 +42,7 @@ subroutine plumerise(data,m1,m2,m3,ia,iz,ja,jz,             &
 
 !  integer, intent(in) :: PLUMERISE_flag
   real(kind=kind_phys) :: frp_inst   ! This is the instantenous FRP, at a given time step
+  real(kind=kind_phys) :: g, cp, rgas, cpor
 
   integer :: ng,m1,m2,m3,ia,iz,ja,jz,ibcon,mynum,i,j,k,imm,ixx,ispc !,nspecies
 
@@ -146,7 +145,7 @@ subroutine plumerise(data,m1,m2,m3,ia,iz,ja,jz,             &
 !  enddo
 
          !- get envinronmental state (temp, water vapor mix ratio, ...)
-         call get_env_condition(coms,1,m1,kmt,wind_eff,ktau,errmsg,errflg)
+         call get_env_condition(coms,1,m1,kmt,wind_eff,ktau,g,cp,rgas,cpor,errmsg,errflg)
          if(errflg/=0) return
 
          !- loop over the four types of aggregate biomes with fires for plumerise version 1
@@ -221,13 +220,16 @@ subroutine plumerise(data,m1,m2,m3,ia,iz,ja,jz,             &
 end subroutine plumerise
 !-------------------------------------------------------------------------
 
-subroutine get_env_condition(coms,k1,k2,kmt,wind_eff,ktau,errmsg,errflg)
+subroutine get_env_condition(coms,k1,k2,kmt,wind_eff,ktau,g,cp,rgas,cpor,errmsg,errflg)
 
 !se module_zero_plumegen_coms
 !use rconstants
 implicit none
 type(plumegen_coms), pointer :: coms
+real(kind=kind_phys) :: g,cp,rgas,cpor
 integer :: k1,k2,k,kcon,klcl,kmt,nk,nkmid,i
+real(kind=kind_phys),parameter :: p1000mb = 100000.  ! p at 1000mb (pascals)
+real(kind=kind_phys),parameter :: p00=p1000mb
 real(kind=kind_phys) :: znz,themax,tlll,plll,rlll,zlll,dzdd,dzlll,tlcl,plcl,dzlcl,dummy
 !integer :: n_setgrid = 0 
 integer :: wind_eff,ktau

smoke/rrfs_smoke_lsdep_wrapper.F90

@@ -4,7 +4,6 @@
 
  module rrfs_smoke_lsdep_wrapper
 
-   use physcons,        only : g => con_g, pi => con_pi
    use machine ,        only : kind_phys
    use rrfs_smoke_config
    use dep_wet_ls_mod
@@ -28,7 +27,7 @@ module rrfs_smoke_lsdep_wrapper
 !>\section rrfs_smoke_lsdep_wrapper GSD Chemistry Scheme General Algorithm
 !> @{
     subroutine rrfs_smoke_lsdep_wrapper_run(im, kte, kme, ktau, dt,     &
-                   rain_cpl, rainc_cpl,                                 &
+                   rain_cpl, rainc_cpl, g,                              &
                    pr3d, ph3d,phl3d, prl3d, tk3d, us3d, vs3d, spechum,  &
                    w, dqdt, ntrac,ntsmoke,ntdust,                       &
                    gq0,qgrs,wetdep_ls_opt_in,                    &
@@ -39,7 +38,7 @@ subroutine rrfs_smoke_lsdep_wrapper_run(im, kte, kme, ktau, dt,     &
 
     integer,        intent(in) :: im,kte,kme,ktau
     integer,        intent(in) :: ntrac,ntsmoke,ntdust
-    real(kind_phys),intent(in) :: dt
+    real(kind_phys),intent(in) :: dt,g
 
     integer, parameter :: ids=1,jds=1,jde=1, kds=1
     integer, parameter :: ims=1,jms=1,jme=1, kms=1
@@ -119,7 +118,7 @@ subroutine rrfs_smoke_lsdep_wrapper_run(im, kte, kme, ktau, dt,     &
     call rrfs_smoke_prep_lsdep(data,ktau,dtstep,                        &
         pr3d,ph3d,phl3d,tk3d,prl3d,us3d,vs3d,spechum,w, dqdt,           &
         rri,t_phy,u_phy,v_phy,p_phy,rho_phy,dz8w,p8w,                   &
-        t8w,dqdti,z_at_w,vvel,                                          &
+        t8w,dqdti,z_at_w,vvel,g,                                        &
         ntsmoke,ntdust,                                                 &
         ntrac,gq0,num_chem, num_moist,                                  &
         ppm2ugkg,moist,chem,                                            &
@@ -138,7 +137,7 @@ subroutine rrfs_smoke_lsdep_wrapper_run(im, kte, kme, ktau, dt,     &
        case (WDLS_OPT_NGAC)
          call WetRemovalGOCART(data,its,ite, jts,jte, kts,kte, 1,1, dt, &
                                num_chem,var_rmv,chem,p_phy,t_phy,       &
-                               rho_phy,dqdti,rcav,rnav,                 &
+                               rho_phy,dqdti,rcav,rnav, g,              &
                                ims,ime, jms,jme, kms,kme)
          !if (chem_rc_check(localrc, msg="Failure in NGAC wet removal scheme", &
          !  file=__FILE__, line=__LINE__, rc=rc)) return
@@ -170,7 +169,7 @@ end subroutine rrfs_smoke_lsdep_wrapper_run
   subroutine rrfs_smoke_prep_lsdep(data,ktau,dtstep,                        &
         pr3d,ph3d,phl3d,tk3d,prl3d,us3d,vs3d,spechum,w,dqdt,           &
         rri,t_phy,u_phy,v_phy,p_phy,rho_phy,dz8w,p8w,                  &
-        t8w,dqdti,z_at_w,vvel,                                         &
+        t8w,dqdti,z_at_w,vvel,g,                                       &
         ntsmoke,ntdust,                                                &
         ntrac,gq0,num_chem, num_moist,                                 &
         ppm2ugkg,moist,chem,                                           &
@@ -182,7 +181,7 @@ subroutine rrfs_smoke_prep_lsdep(data,ktau,dtstep,                        &
 
     !Chem input configuration
     integer, intent(in) :: ktau
-    real(kind=kind_phys), intent(in) :: dtstep
+    real(kind=kind_phys), intent(in) :: dtstep,g
 
     !FV3 input variables
     integer, intent(in) :: ntrac,ntsmoke,ntdust

smoke/rrfs_smoke_lsdep_wrapper.meta

@@ -59,6 +59,14 @@
   type = real
   kind = kind_phys
   intent = in
+[g]
+  standard_name = gravitational_acceleration
+  long_name = gravitational acceleration
+  units = m s-2
+  dimensions = ()
+  type = real
+  kind = kind_phys
+  intent = in
 [pr3d]
   standard_name = air_pressure_at_interface
   long_name = air pressure at model layer interfaces
@@ -147,14 +155,14 @@
   type = integer
   intent = in
 [ntsmoke]
-  standard_name = index_for_smoke
+  standard_name = index_for_smoke_in_tracer_concentration_array
   long_name = tracer index for smoke
   units = index
   dimensions = ()
   type = integer
   intent = in
 [ntdust]
-  standard_name = index_for_dust
+  standard_name = index_for_dust_in_tracer_concentration_array
   long_name = tracer index for dust
   units = index
   dimensions = ()
@@ -177,7 +185,7 @@
   kind = kind_phys
   intent = inout
 [wetdep_ls_opt_in]
-  standard_name = rrfs_smoke_wetdep_ls_opt
+  standard_name = control_for_smoke_wet_deposition
   long_name = rrfs smoke large scale wet deposition option
   units = index
   dimensions = ()

smoke/rrfs_smoke_postpbl.meta

@@ -22,14 +22,14 @@
   type = integer
   intent = in
 [ntsmoke]
-  standard_name = index_for_smoke
+  standard_name = index_for_smoke_in_tracer_concentration_array
   long_name = tracer index for smoke
   units = index
   dimensions = ()
   type = integer
   intent = in
 [ntdust]
-  standard_name = index_for_dust
+  standard_name = index_for_dust_in_tracer_concentration_array
   long_name = tracer index for dust
   units = index
   dimensions = ()