feat(migration_name): allow migrations with custom table name #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
requested changes
Mar 30, 2021
| schema_name = | ||
| :guardian | ||
| |> Application.fetch_env!(Guardian.DB) | ||
| |> Keyword.get(:schema_name, "guardian_tokens") |
There was a problem hiding this comment.
I would suggest to add some documentation about it
There was a problem hiding this comment.
Hmmm, where's the best location for it? README or moduledoc?
There was a problem hiding this comment.
For the most part, moduledoc first and then README
yordis
approved these changes
Apr 4, 2021
|
🚀 🚀 🚀 🚀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested from issue, this PR allows to use migration with custom schema names from the config. I also added the
temporary_envdependency that allows to test temporary configs from the application.Feel free to make changes :)
Closes #118.