From be15a410779d200d624a7340aebd7daccf67fa61 Mon Sep 17 00:00:00 2001 From: tzing Date: Sat, 16 Mar 2024 14:46:47 +0800 Subject: [PATCH] chore: no auth --- secrets_env/providers/vault/auth/__init__.py | 4 ++-- secrets_env/providers/vault/auth/base.py | 4 ++-- tests/providers/vault/auth/test_auth.py | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/secrets_env/providers/vault/auth/__init__.py b/secrets_env/providers/vault/auth/__init__.py index d8fc461e..4d4173a9 100644 --- a/secrets_env/providers/vault/auth/__init__.py +++ b/secrets_env/providers/vault/auth/__init__.py @@ -27,8 +27,8 @@ def create_auth_by_name(url: Url, config: dict) -> Auth: from secrets_env.providers.vault.auth.userpass import LDAPAuth return LDAPAuth.create(url, config) elif method == "null": - from secrets_env.providers.vault.auth.base import NullAuth - return NullAuth.create(url, config) + from secrets_env.providers.vault.auth.base import NoAuth + return NoAuth.create(url, config) elif method == "oidc": from secrets_env.providers.vault.auth.oidc import OpenIDConnectAuth return OpenIDConnectAuth.create(url, config) diff --git a/secrets_env/providers/vault/auth/base.py b/secrets_env/providers/vault/auth/base.py index 81826200..f8838cf2 100644 --- a/secrets_env/providers/vault/auth/base.py +++ b/secrets_env/providers/vault/auth/base.py @@ -35,7 +35,7 @@ def login(self, client: httpx.Client) -> str | None: """Login and get token.""" -class NullAuth(Auth): +class NoAuth(Auth): """No authentication. This class is used when no authentication is required. @@ -46,7 +46,7 @@ class NullAuth(Auth): token: str = "" @classmethod - def create(cls, url: Any, config: dict[str, Any]) -> NullAuth: + def create(cls, url: Any, config: dict[str, Any]) -> NoAuth: return cls() def login(self, client: Any) -> str: diff --git a/tests/providers/vault/auth/test_auth.py b/tests/providers/vault/auth/test_auth.py index b6dd571e..ed76d90c 100644 --- a/tests/providers/vault/auth/test_auth.py +++ b/tests/providers/vault/auth/test_auth.py @@ -4,7 +4,7 @@ from pydantic_core import Url from secrets_env.providers.vault.auth import create_auth_by_name -from secrets_env.providers.vault.auth.base import Auth, NullAuth +from secrets_env.providers.vault.auth.base import Auth, NoAuth @pytest.mark.parametrize( @@ -12,7 +12,7 @@ [ ("basic", "secrets_env.providers.vault.auth.userpass.BasicAuth.create"), ("ldap", "secrets_env.providers.vault.auth.userpass.LDAPAuth.create"), - ("null", "secrets_env.providers.vault.auth.base.NullAuth.create"), + ("null", "secrets_env.providers.vault.auth.base.NoAuth.create"), ("oidc", "secrets_env.providers.vault.auth.oidc.OpenIDConnectAuth.create"), ("okta", "secrets_env.providers.vault.auth.userpass.OktaAuth.create"), ("radius", "secrets_env.providers.vault.auth.userpass.RADIUSAuth.create"), @@ -30,13 +30,13 @@ def test_create_auth_by_name_fail(): create_auth_by_name(Url("https://example.com/"), {"method": "invalid"}) -class TestNullAuth: +class TestNoAuth: def test_login(self): - auth = NullAuth() + auth = NoAuth() assert auth.login(Mock()) == "" - auth = NullAuth(token="test") + auth = NoAuth(token="test") assert auth.login(Mock()) == "test" def test_create(self): - assert isinstance(NullAuth.create(Url("https://example.com/"), {}), NullAuth) + assert isinstance(NoAuth.create(Url("https://example.com/"), {}), NoAuth)