setuptools 69 includes type information by default #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Feb 14, 2025
| assert pkg_data.package_data == ( | ||
| {"singlefilepkg-stubs": ["__init__.pyi", "METADATA.toml", "py.typed"]} | ||
| ) | ||
| assert pkg_data.package_data == ({"singlefilepkg-stubs": ["METADATA.toml"]}) |
There was a problem hiding this comment.
Tests were checking for strings in package_data, but I don't think there's any test to ensure that the right files are actually collected.
srittau
reviewed
Feb 14, 2025
| package_data[pkg_name + SUFFIX] = [*stub_files, META] | ||
| pkg_data = PackageData(base_path, package_data) | ||
| for package in pkg_data.top_level_non_namespace_packages: | ||
| pkg_data.add_file(package, "py.typed") |
There was a problem hiding this comment.
As far as I can see, this is the only call of PackageData.add_file(), so we can remove that method.
Comment on lines
-233
to
-234
| elif file == "py.typed": | ||
| result.append(os.path.relpath(os.path.join(root, file), top)) |
There was a problem hiding this comment.
By removing this, I'd expect this function to crash, as the build directory will have py.typed files and the next elif branch checks for unknown files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112