-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypedDataset.selectMany & co capped at arity 22 #207
Comments
The bigger issue at hand is the usage of tuples rather than records, right? |
Indeed! But switching to a record representation would be much bigger of a change. We went back and forth between the two options and stick to this one because it's close to vanilla and tries to not expose types from |
Ok. Perhaps we should revisit this question as I'd love to solve #188 :-) |
From my work on #206, I have also wondered why we do not work with TypedDataset of records directly, as it will simplify a lot TypedTransformer/TypedEstimator code flow by removing the need to write each intermediate transformed case class. |
Not sure if this is the right issue (#188?) to chime in on this, but as I start using frameless in anger, I too would put a vote toward supporting record types and exposing shapeless to the end user. |
As inactive for ~4y, closing it for now. |
Due to their used of
shapeless.ops.hlist.Tupler
,withColumn
,selectMany
,aggMany
andgroupByMany
are limited to output tuples of size 22. There could be several ways around that, a simple option would be to add alternate implementations of these methods that take a type argument for the "targeted" case class (instead of using tuples). I would start by fixingwithColumn
which looks like the most urgent.The text was updated successfully, but these errors were encountered: