From 0243ef2be6f515e12c0d48b4b89c79260e5fe6f2 Mon Sep 17 00:00:00 2001 From: "Kai(luo) Wang" Date: Fri, 18 Oct 2019 14:36:26 -0400 Subject: [PATCH] address Luka's feedback --- core/src/main/scala/cats/Bifoldable.scala | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/src/main/scala/cats/Bifoldable.scala b/core/src/main/scala/cats/Bifoldable.scala index a41f9c27c95..42bd4ffcf11 100644 --- a/core/src/main/scala/cats/Bifoldable.scala +++ b/core/src/main/scala/cats/Bifoldable.scala @@ -26,8 +26,10 @@ import simulacrum.typeclass val G = ev } - def bifold[A, B](fab: F[A, B])(implicit A: Monoid[A], B: Monoid[B], C: Monoid[(A, B)]): (A, B) = + def bifold[A, B](fab: F[A, B])(implicit A: Monoid[A], B: Monoid[B]): (A, B) = { + import cats.instances.tuple._ bifoldMap(fab)((_, B.empty), (A.empty, _)) + } } private[cats] trait ComposedBifoldable[F[_, _], G[_, _]] extends Bifoldable[λ[(α, β) => F[G[α, β], G[α, β]]]] {