Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds size="n" to <select multiple> #20851

Closed
wants to merge 1 commit into from
Closed

Conversation

dherges
Copy link

@dherges dherges commented Oct 6, 2016

Keeps height in chrome

screen shot 2016-10-06 at 19 33 14

screen shot 2016-10-06 at 19 33 36

Keeps height in chrome
@cvrebert
Copy link
Collaborator

cvrebert commented Oct 7, 2016

I would be more inclined to call that either a bug in our CSS or a bug in Chrome.

@dherges
Copy link
Author

dherges commented Oct 7, 2016

It's a bit unclear. From a quick googling / stack overflow, in CSS the only way to seems to be set a fixed height.

<select> spec says:

[..] represents the number of rows in the list that should be visible at one time.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select#Attributes

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 7, 2016

I mean, the focus outline overflowing the bounds of the select like in your screenshot absolutely should not happen.

@dherges
Copy link
Author

dherges commented Oct 7, 2016

Sure, if I start to add more <option> elements without the size attr, it begins to look like that:

screen shot 2016-10-07 at 10 08 11

Figured out that an overflow-y: auto on the <select> fixes that broken display:

screen shot 2016-10-07 at 10 11 38

@dherges
Copy link
Author

dherges commented Oct 7, 2016

This should've been fixed in #20428, see discussion in #20779

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 7, 2016

Closing as duplicate.

@cvrebert cvrebert closed this Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants