Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollspy: fix wrong activation of all nested links #20304

Merged
merged 2 commits into from
Dec 23, 2016
Merged

scrollspy: fix wrong activation of all nested links #20304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b80f66
fix wrong activation of all nested links;
mr-july Jul 14, 2016
85b5f0c
use template instead of string concatenation
mr-july Jul 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/src/scrollspy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ const ScrollSpy = (($) => {
} else {
// todo (fat) this is kinda sus...
// recursively add actives to tested nav-links
$link.parents(Selector.LI).find(Selector.NAV_LINKS).addClass(ClassName.ACTIVE)
$link.parents(Selector.LI).find(`> ${Selector.NAV_LINKS}`).addClass(ClassName.ACTIVE)
}

$(this._scrollElement).trigger(Event.ACTIVATE, {
Expand Down