-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible implementation to address #13183 #13788
Conversation
@@ -24,24 +24,29 @@ | |||
this.$backdrop = | |||
this.isShown = null | |||
this.scrollbarWidth = 0 | |||
this.remoteUrl = this.options.remoteUrl || this.options.remote && this.options.remote.url || this.options.remote | |||
this.disposeOnHide = this.options.remoteCache === false || this.options.remote && this.options.remote.cache === false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ===
here? You wanna be really sure that they explicitly want this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to prevent against null/undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-remote-cache="false" very different from not specifying data-remote-cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null
and undefined
both are not == false
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know… am i missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh '' == false
which i could see happening in a data attr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the api explicitly takes a boolean, so i think it makes sense to be explicit… but also dont really care
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly what I was asking with
You wanna be really sure that they explicitly want this?
So, never mind then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sorry, i was having trouble following
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify just in case, I'm perfectly fine with whatever operator you choose obviously, just curious. :)
At this point, I'm in favor of deprecating |
(If merged, would implement #13087.) |
I'm fine either way. I wasn't super keen on it, but also people non stop complained about it… and i can see the use case where it's nice to be able to have a data attr load in content if you dont know what you are doing and just trying to hack up something quick/dirty. I'm actually thinking that in 4.0 (or sooner) i want to add Then in that case i could see an option like |
possible implementation to address #13183