Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible implementation to address #13183 #13788

Closed
wants to merge 1 commit into from
Closed

possible implementation to address #13183 #13788

wants to merge 1 commit into from

Conversation

fat
Copy link
Member

@fat fat commented Jun 11, 2014

possible implementation to address #13183

@@ -24,24 +24,29 @@
this.$backdrop =
this.isShown = null
this.scrollbarWidth = 0
this.remoteUrl = this.options.remoteUrl || this.options.remote && this.options.remote.url || this.options.remote
this.disposeOnHide = this.options.remoteCache === false || this.options.remote && this.options.remote.cache === false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why === here? You wanna be really sure that they explicitly want this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to prevent against null/undefined

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-remote-cache="false" very different from not specifying data-remote-cache

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null and undefined both are not == false.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know… am i missing something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh '' == false which i could see happening in a data attr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the api explicitly takes a boolean, so i think it makes sense to be explicit… but also dont really care

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what I was asking with

You wanna be really sure that they explicitly want this?

So, never mind then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sorry, i was having trouble following

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify just in case, I'm perfectly fine with whatever operator you choose obviously, just curious. :)

@cvrebert
Copy link
Collaborator

At this point, I'm in favor of deprecating remote and removing it in v4, and thus also not in favor of this feature request. That's just my 2¢ anyway; it's obviously your call.

@cvrebert
Copy link
Collaborator

(If merged, would implement #13087.)

@cvrebert
Copy link
Collaborator

@fat So, should we close #13183?

@fat
Copy link
Member Author

fat commented Jun 11, 2014

At this point, I'm in favor of deprecating remote and removing it in v4, and thus also not in favor of this feature request

I'm fine either way. I wasn't super keen on it, but also people non stop complained about it… and i can see the use case where it's nice to be able to have a data attr load in content if you dont know what you are doing and just trying to hack up something quick/dirty.

I'm actually thinking that in 4.0 (or sooner) i want to add dispose methods to all the plugins which clean up the listeners and unbind data, etc.

Then in that case i could see an option like disposeOnHide or somethign to that effect (which would address this, without having to do the weirdness with the data attrs and would avoid nesting it under remote).

@fat
Copy link
Member Author

fat commented Jun 12, 2014

@cvrebert

i'm going to close this pr. I'll leave it to your discretion if you want to close #13087.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants