Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation $enable-flex Needs Improvement #21304

Closed
imcodingideas opened this issue Dec 6, 2016 · 4 comments
Closed

Documentation $enable-flex Needs Improvement #21304

imcodingideas opened this issue Dec 6, 2016 · 4 comments

Comments

@imcodingideas
Copy link

The documentation is confusing for newcomers looking to get started with sass and flexbox. Currently the documentation says:

  • Open the _variables.scss file and find the $enable-flex variable.
  • Change it from false to true.
  • Recompile, and done!

This is where it gets confusing: Most of us are using task managers like gulp or grunt, and dependency manages like bower. In my case I'm @import "bootstrap"; in my style.scss file. This leaves to questions which I think the documentation needs improvement:

To properly override this variable do I need go into bower_compoonents/bootstrap/scss/ _variables.scss and change it there or do I need to create that file in: /public/assets/sass/ _variables.scss with 1 variable $enable-flex: true

I wouldn't mind updating documentation if I knew this answer myself.

@imcodingideas imcodingideas changed the title Documentation Enable Flex Box Needs Improvement Documentation $enable-flex Needs Improvement Dec 6, 2016
@razh
Copy link
Contributor

razh commented Dec 6, 2016

The documentation should suggest modifying _custom.scss instead. The Getting Started > Options section was updated, but not flexbox.

You can also create your own _custom.scss file and @import it before you @import bootstrap;.

@Starsam80
Copy link
Contributor

If flex is the only thing you need enabled, you could always try @import "bootstrap-flex", but I can't guarantee that will work.

@imcodingideas
Copy link
Author

razh, that worked. :) I created a _custom.scss and @import before. Worked perfectly. :)

@mdo
Copy link
Member

mdo commented Dec 22, 2016

We're, uh, removing the option entirely. 😆 Won't be an issue anymore with #21389—we're going all in on flexbox.

@mdo mdo closed this as completed Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants