Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using ES6 arrow functions instead of $.proxy() #20633

Closed
cvrebert opened this issue Sep 5, 2016 · 2 comments
Closed

Consider using ES6 arrow functions instead of $.proxy() #20633

cvrebert opened this issue Sep 5, 2016 · 2 comments
Labels
js v4

Comments

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 5, 2016

Refs #17673.
@dalamgir
Copy link

dalamgir commented Sep 6, 2016

@cvrebert is this an open issue? If so i'd like to work on it. Can i get this assigned?

@wyaeld
Copy link

wyaeld commented Sep 7, 2016 •
edited
Loading

Slightly related, but should bootstrap be using a styleguide or standards, enforced by eslint etc? (which would cover things like ES6 arrow)

Edit: I see it is, just got tripped up by it not being in the root where I expect it

https://github.com/airbnb/javascript seems to be the most popular, but I can't judge its overall appropriateness for the project.

@bardiharborow bardiharborow mentioned this issue Oct 31, 2016
Merged
@mdo mdo closed this as completed in #21049 Nov 1, 2016
@mdo mdo mentioned this issue Nov 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wyaeld @cvrebert @dalamgir