Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: should carousel captions be hidden by default for small viewports? #18171

Closed
bassjobsen opened this issue Nov 5, 2015 · 2 comments
Closed

v4: should carousel captions be hidden by default for small viewports? #18171

bassjobsen opened this issue Nov 5, 2015 · 2 comments
Labels
css has-pr v4

Comments

@bassjobsen
Copy link
Contributor

See:

bootstrap/scss/_carousel.scss

Line 199 in 4d17a04

// Hidden by default for smaller viewports.

Should i remove the comment or implement it?
@bassjobsen bassjobsen mentioned this issue Nov 5, 2015
Closed
@mdo
Copy link
Member

mdo commented Nov 15, 2015

Yeah, they should be hidden.

@bassjobsen bassjobsen mentioned this issue Nov 15, 2015
Closed
@RyanZim RyanZim mentioned this issue Apr 15, 2016
Closed
@mdo mdo added the has-pr label Nov 26, 2016
@mdo
Copy link
Member

mdo commented Dec 5, 2016

This can be optionally handled with display utilities. Example coming with #21298.

@mdo mdo closed this as completed Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdo @cvrebert @bassjobsen