From ff39e0bf842cbac99126689bc7cfd1fa882d5d93 Mon Sep 17 00:00:00 2001 From: Catalin Zalog Date: Sat, 14 Mar 2020 10:41:38 +0200 Subject: [PATCH 1/5] feat(css): groups hr element --- scss/_variables.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scss/_variables.scss b/scss/_variables.scss index 26bbb13931d0..509a364ee597 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -428,6 +428,7 @@ $blockquote-small-color: $gray-600 !default; $blockquote-small-font-size: $small-font-size !default; $blockquote-font-size: $font-size-base * 1.25 !default; +$hr-margin-y: $spacer !default; $hr-color: inherit !default; $hr-height: $border-width !default; $hr-opacity: .25 !default; @@ -446,8 +447,6 @@ $list-inline-padding: .5rem !default; $mark-bg: #fcf8e3 !default; -$hr-margin-y: $spacer !default; - // Tables // From 4d4400e5ca0e55bd7e9762fee1794e7424fa1db7 Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Sat, 22 Feb 2020 21:48:14 +0100 Subject: [PATCH 2/5] Fix pseudo paddings and height --- scss/_reboot.scss | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/scss/_reboot.scss b/scss/_reboot.scss index d815baea09ef..9f63ab68a8dc 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -528,9 +528,18 @@ legend { // Fix height of inputs with a type of datetime-local, date, month, week, or time // See https://github.com/twbs/bootstrap/issues/18842 -::-webkit-datetime-edit { - overflow: visible; - line-height: 0; +::-webkit-datetime-edit-fields-wrapper, +::-webkit-datetime-edit-text, +::-webkit-datetime-edit-minute, +::-webkit-datetime-edit-hour-field, +::-webkit-datetime-edit-day-field, +::-webkit-datetime-edit-month-field, +::-webkit-datetime-edit-year-field { + padding: 0; +} + +::-webkit-inner-spin-button { + height: auto; } // 1. Correct the outline style in Safari. From 8501f2413f9c4af8347f13912773ace24d4b65f0 Mon Sep 17 00:00:00 2001 From: Catalin Zalog Date: Sun, 15 Mar 2020 22:10:08 +0200 Subject: [PATCH 3/5] style: fixes indent (#30396) --- site/content/docs/4.3/getting-started/rfs.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/site/content/docs/4.3/getting-started/rfs.md b/site/content/docs/4.3/getting-started/rfs.md index 0cdd08257699..2f18524014c5 100644 --- a/site/content/docs/4.3/getting-started/rfs.md +++ b/site/content/docs/4.3/getting-started/rfs.md @@ -66,8 +66,8 @@ In this example, we use one of Bootstrap's built-in [responsive breakpoint mixin ```scss .selector { @include media-breakpoint-down(lg) { - padding: rfs-fluid-value(2rem); - font-size: rfs-fluid-value(1.125rem); + padding: rfs-fluid-value(2rem); + font-size: rfs-fluid-value(1.125rem); } } ``` From fef94bf1638acf8d8b31508eadf61c79e8c080f9 Mon Sep 17 00:00:00 2001 From: Catalin Zalog Date: Sun, 15 Mar 2020 22:21:19 +0200 Subject: [PATCH 4/5] style: applies ascending order --- scss/_utilities.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/_utilities.scss b/scss/_utilities.scss index 1a85165dc2e3..a872c6bb9ac4 100644 --- a/scss/_utilities.scss +++ b/scss/_utilities.scss @@ -29,8 +29,8 @@ $utilities: map-merge( property: box-shadow, class: shadow, values: ( - sm: $box-shadow-sm, null: $box-shadow, + sm: $box-shadow-sm, lg: $box-shadow-lg, none: none, ) From 52c5b06f1c0ed1aaed67012dcb29198618080f85 Mon Sep 17 00:00:00 2001 From: Catalin Zalog Date: Sun, 15 Mar 2020 16:28:18 +0200 Subject: [PATCH 5/5] fix(css): adds a new opacity var Fixes beeing able to control `.is-valid` & `.is-invalid` input:focus opacity --- scss/_variables.scss | 7 ++++--- scss/mixins/_forms.scss | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/scss/_variables.scss b/scss/_variables.scss index 509a364ee597..71fabc58db58 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -496,9 +496,10 @@ $input-btn-font-family: null !default; $input-btn-font-size: $font-size-base !default; $input-btn-line-height: $line-height-base !default; -$input-btn-focus-width: .2rem !default; -$input-btn-focus-color: rgba($component-active-bg, .25) !default; -$input-btn-focus-box-shadow: 0 0 0 $input-btn-focus-width $input-btn-focus-color !default; +$input-btn-focus-width: .2rem !default; +$input-btn-focus-color-opacity: .25 !default; +$input-btn-focus-color: rgba($component-active-bg, $input-btn-focus-color-opacity) !default; +$input-btn-focus-box-shadow: 0 0 0 $input-btn-focus-width $input-btn-focus-color !default; $input-btn-padding-y-sm: .25rem !default; $input-btn-padding-x-sm: .5rem !default; diff --git a/scss/mixins/_forms.scss b/scss/mixins/_forms.scss index ab612334f439..18735599421e 100644 --- a/scss/mixins/_forms.scss +++ b/scss/mixins/_forms.scss @@ -58,7 +58,7 @@ &:focus { border-color: $color; - box-shadow: 0 0 0 $input-focus-width rgba($color, .25); + box-shadow: 0 0 0 $input-focus-width rgba($color, $input-btn-focus-color-opacity); } } }