Json Each and Json Tree #1088
Closed
Json Each and Json Tree #1088
+893
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed due to inactivity. Please feel free to reopen it if you have further updates. |
penberg
added a commit
that referenced
this pull request
Jun 4, 2025
This PR adds support for table-valued functions for PRAGMAs (see the [PRAGMA functions section](https://www.sqlite.org/pragma.html)). Additionally, it introduces built-in table-valued functions. I considered using extensions for this, but there are several reasons in favor of a dedicated mechanism: * It simplifies the use of internal functions, structs, etc. For example, when implementing `json_each` and `json_tree`, direct access to internals was necessary: #1088 * It avoids FFI overhead. [Benchmarks](https://github.com/piotrrzysko/li mbo/blob/pragma_vtabs_bench/core/benches/pragma_benchmarks.rs) on my hardware show that `pragma_table_info()` implemented as an extension is 2.5× slower than the built-in version. Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com> Closes #1642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Json Each and Json Tree. My implementation almost matches the one with sqlite. It is different in two ways: in the assigning of arbitrary ids and in assigning path locators (which is believe is slightly buggy in sqlite). The arbitrary id assignment would not affect users of these functions are they are relative to each other, as what matters is that each item has a unique id assigned to them.
With regards to the path locators, I believe it is buggy as can be seen in the following screenshot:
As you can see, in the last two json_tree queries their path and fullkey values are equal where they should differ in their array locators. It seems that when you pass a path containing an array locator to json_tree, it will then substitute it with a
[0]instead.I would like some guidance on how to proceed. Should I try to hack my implementation to accommodate with the way ids are incremented and with this path irregularity? Or should we stick with my implementation for now?
After a response, I intend to add and modify the tests depending on the direction we wish to take, as currently they won't pass due to this divergence in implementation.
Also, this PR depends on #1054 to be merged to be able to return Json instead of Text for the value column.