Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing behaviour of navbar links #151

Closed
hyanwong opened this issue Nov 17, 2022 · 7 comments
Closed

Confusing behaviour of navbar links #151

hyanwong opened this issue Nov 17, 2022 · 7 comments

Comments

@hyanwong
Copy link
Member

hyanwong commented Nov 17, 2022

A really minor thing, but it keeps bugging me. If I click on e.g. python-api.html#treesequence-api, the right
hand navbar doesn't expand the "TreeSequence API" section to show the various subcategories within that section. Instead, I have to scroll down a fraction to get the navbar to show the subcategories in that section.

This means that e.g. clicking on the link in the navbar doesn't expand the section, as you might hope. In fact, when you click on one of those navbar links, the previous topic is expanded, which is really confusing.

E.g. here's the result I get when clicking on "Tables and Table Collections" in the navbar (it looks like Tree API->Export is highlighted, because that's the subsubsection before the "Tables and Table Collections" heading).

Screenshot 2022-11-17 at 18 32 25

@benjeffery
Copy link
Member

I think this might get fixed if I pull in the upstream changes from sphinx-book-theme.

@hyanwong
Copy link
Member Author

Oh, that would be good, thanks. It's a minor thing, but bugs me a lot!

@benjeffery benjeffery added this to the Next update wave milestone Nov 18, 2022
@hyanwong
Copy link
Member Author

I think this might get fixed if I pull in the upstream changes from sphinx-book-theme.

Did you manage to see if this fixed the problem @benjeffery ?

@daikitag
Copy link
Contributor

daikitag commented Jun 13, 2023

It seems that it is a bug from the previous version of sphinx-book-theme, and they have fixed it in their new release.
executablebooks/sphinx-book-theme#677
It might be possible to fix the issue after incorporating the recent release of sphink-book-theme

@benjeffery
Copy link
Member

Ah good, have they re-organised their CSS though? Might be easier just to port across the fix.

@daikitag
Copy link
Contributor

daikitag commented Jun 13, 2023

It seems that they had fixed their CSS as well, but 100+ files were changed compared with the version that you used to build tskit-book-theme. Do you think you can successfully merge their current version to tskit-book-theme? I can try changing it, but I think it would be difficult for me, as I'm not sure about which files you had modified from sphix-book-theme.

@benjeffery
Copy link
Member

This still seems to happen, when using the latest docs that use sphinx-book-theme directly. I'll keep updating as they release, and it might get fixed, but I'm closing here as there is nothing we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants