Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is manifest version 3 support planned? #284

Closed
avalanche1 opened this issue Jun 26, 2022 · 4 comments · Fixed by #297
Closed

Is manifest version 3 support planned? #284

avalanche1 opened this issue Jun 26, 2022 · 4 comments · Fixed by #297

Comments

@avalanche1
Copy link

avalanche1 commented Jun 26, 2022

Interesting, since the notion of background script is now deprecated in favour of service workers

@colbat
Copy link

colbat commented Aug 4, 2022

Looks like it can already be used with Manifest v3. At least in my case it works well so far. Please see #244 (comment)

And you can find an example repo I made here: https://github.com/colbat/webext-redux-event-driven

@hibroseph
Copy link

hibroseph commented Dec 19, 2022

@colbat I ran into a specific problem I am trying to trouble shoot and I wonder if you have any direction on whether this could be a webext-redux issue or if I am using it incorrectly.

I have written code to reactivate it following your examples when I do an action on a script I have running on the webpage. This works as expected and the change is made, sent to the backend redux store, and then rerendered on the page.

The problem comes in when I go to another tab (with the service worker already reactivated from another tab) and do an action (such a change a color of something I am rendering in my react app), I see the change made to the redux store in the background code, but I do not see my app getting updated with the change to the store.

Let me know if you have any quick insight into this

Update: I am seem to fix this by hooking into the onDisconnect callback on the port and creating a simple middleware to see if we have been disconnected, and if so, reconnect

@SmoothRecursion
Copy link

@colbat I ran into a specific problem I am trying to trouble shoot and I wonder if you have any direction on whether this could be a webext-redux issue or if I am using it incorrectly.

I have written code to reactivate it following your examples when I do an action on a script I have running on the webpage. This works as expected and the change is made, sent to the backend redux store, and then rerendered on the page.

The problem comes in when I go to another tab (with the service worker already reactivated from another tab) and do an action (such a change a color of something I am rendering in my react app), I see the change made to the redux store in the background code, but I do not see my app getting updated with the change to the store.

Let me know if you have any quick insight into this

Update: I am seem to fix this by hooking into the onDisconnect callback on the port and creating a simple middleware to see if we have been disconnected, and if so, reconnect

Could you explain this a bit more, I am running into the same issue. Are you reconnecting from the content script side? @hibroseph

@SidneyNemzer
Copy link
Collaborator

MV3 support will be implemented by #297. Sorry for the wait!

@SidneyNemzer SidneyNemzer mentioned this issue Jun 19, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants