Skip to content

Commit b2b31f3

Browse files
committed
docs(upgrade-guide.md): correct terminology from 'diff' to 'drift' for clarity
refactor(variables.tf): reorder variables for better logical grouping and readability
1 parent 3c96aac commit b2b31f3

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

upgrade-guide.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Few Modules are shifted to using count block to support this feature.
1818
terraform state mv 'google_container_node_pool.control_plane_pool' 'google_container_node_pool.control_plane_pool[0]' # If control plane is enabled, else skip this step
1919
```
2020

21-
3. Run terraform plan to check if there are is diff
21+
3. Run terraform plan to check if there is any drift
2222

2323
```bash
2424
terraform plan

variables.tf

+8-9
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ variable "use_existing_cluster" {
88
default = false
99
}
1010

11-
variable "cluster_name" {
12-
description = "Name of the cluster. If use_existing_cluster is enabled name is used to fetch details of existing cluster"
13-
type = string
14-
}
1511

1612
variable "cluster_node_locations" {
1713
description = "AZ for nodes - this should match the region"
@@ -28,10 +24,9 @@ variable "max_pods_per_node" {
2824
# Cluster Configuration
2925
################################################################################
3026

31-
variable "tags" {
32-
description = "A map of tags to add to all resources. Tags are key-value pairs used for grouping and filtering"
33-
type = map(string)
34-
default = {}
27+
variable "cluster_name" {
28+
description = "Name of the cluster. If use_existing_cluster is enabled cluster_name is used to fetch details of existing cluster"
29+
type = string
3530
}
3631

3732
variable "network_tags" {
@@ -49,7 +44,11 @@ variable "project" {
4944
description = "GCP Project"
5045
type = string
5146
}
52-
47+
variable "tags" {
48+
description = "A map of tags to add to all resources. Tags are key-value pairs used for grouping and filtering"
49+
type = map(string)
50+
default = {}
51+
}
5352

5453
################################################################################
5554
# Node Pool Configurations

0 commit comments

Comments
 (0)