Null pointer dereference

[alexeys85]

I've encountered a problem when using reload config command from smcroutectl. Stacktrace shows that this if statement:

smcroute/src/pidfile.c

Lines 77 to 78 in cf5cc48

	if (!access(pidfile_path, R_OK) && pid == pidfile_pid) {
	utimensat(0, pidfile_path, NULL, 0);

becomes true and NULL passes to utimensat function with following dereference:

smcroute/lib/utimensat.c

Line 36 in cf5cc48

TIMESPEC_TO_TIMEVAL(&tv[0], &ts[0]);

[troglobit]

Interesting, you're triggering the replacement function. What libc are you building against?

[troglobit]

(Obviously I'll get on it to fix the utimensat() replacement, I'm just curious.)

[alexeys85]

Well, I'm using Ubuntu 22.04 and just wrongly included utimensat.c to build :)

[troglobit]

Aha, well that should be automatically detected by the configure script. If you're doing some sort of hybrid build, you don't need it on GLIBC. Also, please remember the GNU license restrictions and implications if you're incorporating parts/whole of SMCRoute in another application.

[alexeys85]

We don't incorporate any parts of SMCRoute in our apps. I just wanted to add cmake support :)

[troglobit]

OK, got it! Then FYI, all the stuff in lib/ are replacement functions in case the system doesn't have it.