Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fstab with UUID or LABEL: boot stops and goes into sulogin if device absent, no support for nofail option #421

Closed
az143 opened this issue Dec 17, 2024 · 0 comments · Fixed by #422
Milestone

Comments

@az143
Copy link
Contributor

az143 commented Dec 17, 2024

i found this small issue with 4.8: if you have a fstab'd filesystem on a device that isn't always present, e.g. sd card or usb stick, and which is identified by LABEL= or UUID= in fstab, then 4.8 doesn't boot if the device happens to be absent. finit doesn't deal with the 'nofail' mount option, which should make mount (and fsck) ignore absence errors.

4.7 boots fine with that setup, but that's likely due to bug #400. if your filesystem is listed by block device then both finit versions already work fine, because in that case the presence of the block device file is (checkable and) checked before the fsck invocation. it's just the indirect LABEL'd devices that cause trouble.

i've patched this by making fsck not bail out on error if hasmntopt() indicates 'nofail' was set. the patch is just a few lines, and i'll provide a pull request in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants