Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] remove coding handling breaking changes and unused function #256

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Sep 16, 2024

This PR…

  • removes one unused function and
  • removes the code of handling breaking changes

Considerations and implementations

Release v4.0.0 was released on May 5, 2023.
People who installed wahooMapsCreator before that date and update just now might have files in the user-maps and user-_download folder which are no longer accessed / used / deleted due to change of naming for country files

This also closes #251 / to not redownload files:

  • The first thought was to save the version_last_run earlier, i.e. after downloading files but the the technology of checking for breaking changes and tacking care of them is somehow not the same as now.
  • Then I thought to do nothing to tackle the issue because normally, version_last_run should be set if running successful for a small country/tile.
  • In the end I watched at the location where deletion takes place - the check and handling of breaking changes. Since a user had to use wahooMapsCreator about more than a year ago and not update since then in combination with the small negative impact (files that are no longer accessed) brought the idea to delete the handling of breaking changes. Making room for possible breaking changes in the future ;-)

How to test

  1. use wahooMapsCreator as normal - you should not notice and difference

Pull Request Checklist

Release v4.0.0 was released on May 5, 2023.
People who installed wahooMapsCreator before that date and update just now might have files in the user-maps and user-_download folder which are no longer accessed / used / deleted due to change of naming for country files
@treee111 treee111 added the enhancement New feature or request label Sep 16, 2024
@treee111 treee111 changed the title [FEAT] remove unused function and coding handling breaking changes [FEAT] remove coding handling breaking changes and unused function Sep 16, 2024
@treee111 treee111 merged commit 43e07b4 into develop Sep 16, 2024
2 checks passed
@treee111 treee111 deleted the remove-breaking-changes-coding branch September 16, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed version check if not a git repository
1 participant