Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] macOS: Download mapwriter plugin during usage instead of manually copying during setup #177

Merged
merged 3 commits into from
Feb 3, 2023
Merged

[FEAT] macOS: Download mapwriter plugin during usage instead of manually copying during setup #177

merged 3 commits into from
Feb 3, 2023

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Feb 3, 2023 •
edited
Loading

This PR…

Considerations and implementations

Doing stuff in the same way as already in Windows is a good idea.
With this PR, some refactorings are also included which were found during coding.

How to test

  1. delete mapwriter plugin / whole ~/.openstreetmap directory
  2. run wahooMapsCreator and process a small country
  3. check output of processing and if the mapwriter plugin was downloaded

Pull Request Checklist

@treee111 treee111 added the infrastructure Infrastructure label Feb 3, 2023
@treee111 treee111 mentioned this pull request Feb 3, 2023
Closed
@treee111 treee111 added this to the v4.0.0 milestone Feb 3, 2023
@treee111 treee111 marked this pull request as ready for review February 3, 2023 14:12
@treee111 treee111 changed the title [FEAT] Download mapwriter plugin during usage instead of manually copying during setup [FEAT] macOS: Download mapwriter plugin during usage instead of manually copying during setup Feb 3, 2023
@treee111 treee111 merged commit 1119db5 into release-v4.0.0 Feb 3, 2023
@treee111 treee111 deleted the dl-mapwriter-plugin branch February 3, 2023 14:14
@treee111 treee111 linked an issue Feb 3, 2023 that may be closed by this pull request
macOS: automate the installation even more // setup.py file?! #89
Closed
treee111 added a commit that referenced this pull request May 5, 2023
@treee111
[FEAT] macOS: Download mapwriter plugin during usage instead of manua…
9a54bc5 
…lly copying during setup (#177)

* download mapwriter plugin on macOS identically to Windows

- one manuall step fewer

* move creation of win tooling dir

- function is independent of creating dir  before

* update unittests
alfh pushed a commit to alfh/wahooMapsCreator that referenced this pull request Nov 4, 2023
@treee111 @alfh
[FEAT] macOS: Download mapwriter plugin during usage instead of manua…
3c7b50e 
…lly copying during setup (treee111#177)

* download mapwriter plugin on macOS identically to Windows

- one manuall step fewer

* move creation of win tooling dir

- function is independent of creating dir  before

* update unittests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure Infrastructure
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

macOS: automate the installation even more // setup.py file?!
1 participant
@treee111