Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote machines trying to contact remote machines despite being called remotely themselves #786

Closed
3 of 6 tasks
j-lakeman opened this issue May 4, 2024 · 1 comment
Closed
3 of 6 tasks
Labels
C-bug Something isn't working

Comments

@j-lakeman
Copy link

Erroneous Behavior

remote machines trying to contact themselves / other remote machines upon remote execution

Expected Behavior

remote machines shouldnt "chain" but ignore remote machine entries in topgrade.toml

Steps to reproduce

  1. have a topgrade.toml with remote machines in it
  2. have that same file on remote machine
  3. run topgrade on host
  4. remote machines trying to contact themselves / other remote machines

Possible Cause (Optional)

topgrade doesn't check whether being invoked by another host

Problem persists without calling from topgrade

  • Yes
  • No

Did you run topgrade through Remote Execution

  • Yes
  • No

If yes, does the issue still occur when you run topgrade directlly in your
remote host

  • Yes

  • No

  • Installation
    Homebrew

  • Topgrade version (topgrade -V)
    Topgrade 14.0.1

@j-lakeman j-lakeman added the C-bug Something isn't working label May 4, 2024
@SteveLauC
Copy link
Member

remote machines trying to contact themselves

So I guess in your configuration file, remote_topgrades has user specified, i.e., something like:

[misc]
remote_topgrades = ["user@host"]

If that is the case, yeah, this is bug and it has been fixed in #755


remote machines trying to contact other remote machines upon remote execution

This is the expected behavior since they are specified in the configuration file.

@j-lakeman j-lakeman closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants