Compiled the TrafficLayer component into lib #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batjko
reviewed
Jan 11, 2017
| @@ -0,0 +1,42 @@ | |||
| /* global google */ | |||
| import { | |||
| default as React, | |||
There was a problem hiding this comment.
I'm not sure this import notation should be encouraged. What's the reason you're not doing the normal
import React, { Component } from 'react' here?
There was a problem hiding this comment.
This PR is meant to go on top of #417 but I'm not sure it has been done correctly. His original PR created the TrafficLayer, but he didn't compile it into the code so I took it that extra step in order to get it working correctly.
There was a problem hiding this comment.
I'll admit, I copied HeatmapLayer and changed the relevant bits for TrafficLayer. This is in HeatmapLayer too. I'm happy update them both if desired, but either way, I'd also love to get TrafficLayer into the package.
|
Released 6.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My company needed this feature pretty sharpish so I have gone through the trouble of running
npm run build:lib.This is my very first ReactJS package I have contributed to, so please let me know if that is the correct way to compile the code.
It's currently running very well on my machine, so thank you.