fix(todos): eliminate input mutation from the reducer

tomastrajan · Jan 14, 2018 · 7869cb0 · 7869cb0
1 parent 66af8b4
commit 7869cb0
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/app/examples/todos/todos.reducer.ts b/src/app/examples/todos/todos.reducer.ts
@@ -71,14 +71,11 @@ export function todosReducer(state = initialState, action: TodosActions) {
       });
 
     case TodosActionTypes.TOGGLE:
-      state.items.some((item: Todo) => {
-        if (item.id === action.payload.id) {
-          item.done = !item.done;
-          return true;
-        }
-      });
       return Object.assign({}, state, {
-        items: [...state.items]
+        items: state.items.map(
+          (item: Todo) =>
+            item.id === action.payload.id ? { ...item, done: !item.done } : item
+        )
       });
 
     case TodosActionTypes.REMOVE_DONE: