Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: depend on bytes 1.0 #3058

Closed
carllerche opened this issue Oct 27, 2020 · 4 comments · Fixed by #3301
Closed

io: depend on bytes 1.0 #3058

carllerche opened this issue Oct 27, 2020 · 4 comments · Fixed by #3301
Assignees
@carllerche
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Milestone
v1.0

Comments

@carllerche
Copy link
Member

Before releasing Tokio 1.0, the bytes dependency needs to be updated to bytes 1.0.
@carllerche carllerche added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Oct 27, 2020
@carllerche carllerche added this to the v1.0 milestone Oct 27, 2020
This was referenced Oct 27, 2020
Closed
Closed
@jonhoo
Copy link
Contributor

jonhoo commented Dec 11, 2020

Related bytes milestone for 1.0: https://github.com/tokio-rs/bytes/milestone/3

@taiki-e
Copy link
Member

taiki-e commented Dec 15, 2020

Also, bytes 0.6 milestone still has some open issues: https://github.com/tokio-rs/bytes/milestone/2

@carllerche
Copy link
Member Author

@taiki-e good call. We should triage them.

@taiki-e
Copy link
Member

taiki-e commented Dec 15, 2020

In addition, bytes 0.5 milestone also has some open issues: https://github.com/tokio-rs/bytes/milestone/1
(I didn't notice it because the milestone was closed.)

@carllerche carllerche self-assigned this Dec 19, 2020
carllerche added a commit that referenced this issue Dec 19, 2020
@carllerche
chore: update to bytes 1.0 git branch
780d22b 
Updates the code base to track the `bytes` git branch. This is in
preparation for the 1.0 release.

Closes #3058
@carllerche carllerche mentioned this issue Dec 19, 2020
Merged
carllerche added a commit that referenced this issue Dec 19, 2020
@carllerche
chore: update to bytes 1.0 git branch (#3301)
2893359 
Updates the code base to track the `bytes` git branch. This is in
preparation for the 1.0 release.

Closes #3058
@lukesteensen lukesteensen mentioned this issue Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carllerche carllerche

Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

chore: update to bytes 1.0 git branch tokio-rs/tokio
3 participants
@carllerche @jonhoo @taiki-e