Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update flake.lock #1216

Merged
merged 1 commit into from
Jan 8, 2025
Merged

chore: update flake.lock #1216

merged 1 commit into from
Jan 8, 2025

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Jan 2, 2025

simply cloned the repo and ran nix flake update.

flake.lock hasn't been updated in 2+ years, it was still pinned to using cargo 1.63 or some very old version. Following the tutorial at https://docs.rs/prost-build/latest/prost_build/ didn't work because it would download the latest version of prost_build which requires cargo 1.71.

flake.lock hasn't been updated in 2+ years, it was still pinned to using cargo 1.63 or some very old version. Following the tutorial at https://docs.rs/prost-build/latest/prost_build/ didn't work because it would download the latest version of prost_build which requires cargo 1.71.
@caspermeijn
Copy link
Collaborator

I am not familiar with nix and I don't use it myself. Is this similar to dev containers (as in, you define the setup you need for development)?

I believe this has not been used by anyone for a long time. MSRV 1.64 was in August 2023 and MSRV 1.70 was in February 2024. Is it reasonable to remove flake.lock?

If we keep the setup, then it should be tested in CI so that it can't become outdated anymore. Maybe dependabot can help update it?

Alternatively, can this config be used instead dev containers? Then a single config is used in multiple places. https://github.com/devcontainers/features/tree/main/src/nix

@samlaf
Copy link
Contributor Author

samlaf commented Jan 3, 2025

I am not familiar with nix and I don't use it myself. Is this similar to dev containers (as in, you define the setup you need for development)?

Nix is a full blown package manager, but its shell feature has a similar goal to dev containers yes. Although it runs natively so it doesn’t have the container overhead.

I believe this has not been used by anyone for a long time. MSRV 1.64 was in August 2023 and MSRV 1.70 was in February 2024. Is it reasonable to remove flake.lock?

That’s a good question it might work I’m not sure but the dependabot route would def be more canonical/rwproducible.

If we keep the setup, then it should be tested in CI so that it can't become outdated anymore. Maybe dependabot can help update it?

https://github.com/DeterminateSystems/update-flake-lock This looks like what you’d want.

Alternatively, can this config be used instead dev containers? Then a single config is used in multiple places. https://github.com/devcontainers/features/tree/main/src/nix

not sure what that repo is, but it looks like it installs nix to be used inside dev containers, I would guess similarly to how one would want to use nix inside a dockerfile to get a reproducible image build. I much prefer to not have to deal with dev containers, and just spin up the shell with nix develop github:tokio-rs/prost

@caspermeijn caspermeijn added this pull request to the merge queue Jan 8, 2025
@caspermeijn
Copy link
Collaborator

Thank you for your contribution

Merged via the queue into tokio-rs:master with commit d2445e1 Jan 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants