Alarms set for 12:xx am or 12:xx pm fire at the wrong time

[pcherna]

Running version 2.2.3 under MacOS 10.14.6

I have a few alarms set between 12:15am and 12:30am, and they were firing an hour early:

The bug is in timeService.js, checkTime, which reads:

// convert am/pm to 0-24, am: 1-12 -> 1-12, pm: 1-11,12 -> 13-23,0
if( rMode === 'am' ) {
	rHour = (rHour !== 12) ? rHour : 23;
} else if( rMode === 'pm' ) {
	rHour = (rHour !== 12) ? rHour + 12 : 0;
} // else 24 hour mode

The adjusted values for rHour when rHour begins as 12 are wrong, and should be as follows:

// convert am/pm to 0-24, am: 1-11,12 -> 1-11,0, pm: 1-11,12 -> 13-23,12
if( rMode === 'am' ) {
	rHour = (rHour !== 12) ? rHour : 0;
} else if( rMode === 'pm' ) {
	rHour = (rHour !== 12) ? rHour + 12 : 12;
} // else 24 hour mode

[todbot]

Thank you! I'm prepping a release soon. I'll add this fix in.

[pcherna]

I see the code has some support for 24 hour mode but I couldn't find how to use that. That would have let me avoid the bug till then. Instead, I'm just using an IFTTT trigger for now. -- Cheers, and thanks.